ICP201: Fix B2 version not return in bootup config #22702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
previously approved these changes
Jan 30, 2024
|
The change looks fine, but I'm not able to merge. Can you rebase on
|
cuav-liu1
force-pushed
the
icp20100-b2
branch
from
1077467
to
21dbb7a
Compare
cuav-liu1
force-pushed
the
icp20100-b2
branch
from
21dbb7a
to
07409d9
Compare
|
@dagar. Already rebase on main. |
dagar
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICP20100 B2 version Asic is detected. Boot up sequence is not required for B2 Asic, so returning.
But the
break;is missing.