Commander check reporting improvements #22886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
Such that the focus is on the important keywords. Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
dagar
reviewed
Mar 14, 2024
| @@ -402,15 +402,15 @@ | |||
| }, | |||
| "2": { | |||
| "name": "fallback_posctrl", | |||
| "description": "fallback to Position mode" | |||
| "description": "Position mode" | |||
There was a problem hiding this comment.
Fallback isn't important context?
There was a problem hiding this comment.
I don't think so. All the fields in this enum are fallbacks in the end.
See my screen recording above to see how it looks for the operator. I think in the context it's enough.
There was a problem hiding this comment.
That's the message you'd get when GPS in invalidated in Position flight mode for example.
There was a problem hiding this comment.
And that was an option I had though about once. It adds the key words "failsafe action" before the fallback mode:
I'm not strongly in favor of any, but think the "failsafe action" keywords are not crucial for context.
bkueng
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
The failsafe event messages are a bit long.
Solution
Make them shorter.
That's how it would look like now:
https://github.com/PX4/PX4-Autopilot/assets/26798987/ece1ea4e-74de-473c-8458-a7c24d986d6e
Changelog Entry
For release notes: