Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mc_wind_estimator_tuning: optionally use GNSS velocity #22891

Merged
merged 1 commit into from
Mar 14, 2024
Merged

mc_wind_estimator_tuning: optionally use GNSS velocity #22891

merged 1 commit into from
Mar 14, 2024

Conversation

bresch
Copy link
Member

@bresch bresch commented Mar 14, 2024

Sometimes GNSS is logged but not used.

Simply add --gnss flag to use velocity from vehicle_gps_position instead of vehicle_local_position

@bresch
mc_wind_estimator_tuning: optionally use GNSS velocity
3d33042 
Sometimes GNSS is logged but not used
@bresch bresch added the EKF2 label Mar 14, 2024
@bresch bresch requested a review from fury1895 March 14, 2024 16:22
@bresch bresch self-assigned this Mar 14, 2024
fury1895
fury1895 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@fury1895 fury1895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also quickly verified with some data, thanks!

@bresch bresch merged commit 7c6ecd9 into main Mar 14, 2024
91 of 92 checks passed
@bresch bresch deleted the pr-mc-wind-est-tuning-tool-gnss branch March 14, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fury1895 fury1895 fury1895 approved these changes

Assignees

@bresch bresch

Labels
EKF2
Projects
PX4 EKF
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bresch @fury1895