code: add more style options in .editorconfig
#22920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only option I'm not that sure about is Kconfig. The indentation there seems to vary from file to file. I tried to use what applies to most files. |
Probably because there's no tooling enforcing it. |
dagar
approved these changes
Mar 25, 2024
|
Just thought that maybe there was a project preference, but I guess a consistent style will already help a lot, whether it's 4 or 8 spaces or tabs 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Some file types were missing from the global
.editorconfig.Solution
.editorconfigto support YAML, Kconfig andCMakeLists.txtfiles.Changelog Entry
/
Alternatives
/
Test coverage
/
Context
I wanted to see whether a
.editorconfigwould be accepted before adding all the options. This will also be an ongoing effort as that's easier than adding all the options for all the files at once. People can add files that aren't displayed/edited correctly as they need it.The options are decided both by looking at the developer documentation as well as by checking what most files use (e.g. for YAML where the style isn't documented anywhere).