Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(editorconfig): update newline setting #23122

Merged
merged 1 commit into from
May 15, 2024

Conversation

flyingthingsintothings
Copy link
Contributor

Solved Problem

The setting wasn't consistent with the one used in the Visual Studio Code settings, which caused different newline formatting depending on whether the user uses Visual Studio Code or another editor that uses EditorConfig.

Fixes /

Solution

  • Change newline ending setting in the EditorConfig file to be consistent with the Visual Studio Code setting

Changelog Entry

For release notes:

Feature/Bugfix XYZ
New parameter: XYZ_Z
Documentation: Need to clarify page ... / done, read docs.px4.io/...

Alternatives

Maybe remove the formatting settings from the Visual Studio Code .vscode/settings.json configuration file as the EditorConfig extension is now in the recommended list and it can therefore use the settings from the .editorconfig file.

Test coverage

/

Context

The original EditorConfig was based on the style in most files. After using it for actual development, some errors are showing up that weren't immediately visible by just looking at the files (e.g. due to different settings in Visual Studio Code config), like this one. I will make more PRs if I encounter other problems.

The setting wasn't consistent with the one used in the Visual Studio
Code settings, which caused different newline formatting depending on
whether the user uses Visual Studio Code or another editor that uses
EditorConfig.
@dagar dagar merged commit 9fd1c54 into PX4:main May 15, 2024
87 of 89 checks passed
@flyingthingsintothings flyingthingsintothings deleted the pr-editorconfig-fix branch May 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants