style(editorconfig): update newline setting #23122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
The setting wasn't consistent with the one used in the Visual Studio Code settings, which caused different newline formatting depending on whether the user uses Visual Studio Code or another editor that uses EditorConfig.
Fixes /
Solution
Changelog Entry
For release notes:
Alternatives
Maybe remove the formatting settings from the Visual Studio Code
.vscode/settings.json
configuration file as the EditorConfig extension is now in the recommended list and it can therefore use the settings from the.editorconfig
file.Test coverage
/
Context
The original EditorConfig was based on the style in most files. After using it for actual development, some errors are showing up that weren't immediately visible by just looking at the files (e.g. due to different settings in Visual Studio Code config), like this one. I will make more PRs if I encounter other problems.