-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boat Module #23148
base: main
Are you sure you want to change the base?
Boat Module #23148
Conversation
Hi @PerFrivik |
Yes of course! I used the setup that @junwoo091400 set up quite a while ago, which can be found here. |
Keep in mind this PR is subject to change, I will most likely replace the L1 with a pure pursuit. |
@PerFrivik We'll need to discuss then when it goes in for docs. |
Yes I agree, I'll tag you then! |
float32 yaw_rate # [rad] yaw_rate | ||
bool closed_loop_yaw_rate_control # true if rudder angle is controlled using encoder feedback, false if direct feed-forward | ||
|
||
# TOPICS boat_setpoint boat_control_output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kind of pedantic, but if it makes sense try to keep the actual data type (the .msg file) more generically useful (speed and heading setpoint?) then the actual topic could be the specific boat_setpoint, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thank you for your input! I'm doing quite the revamp on the controller and this was exactly one of my questions.
Solved Problem
This PR integrates the Boat module with a new architecture that supports modular components such as BoatControl, BoatGuidance, and BoatKinematics. This architecture facilitates the integration with different drive systems like Differential Drive and Ackermann Drive. The module is designed for scalability, allowing for future adaptations to various types of boats by adjusting components like kinematics to suit specific needs.
Fixes #{Github issue ID}
Solution
Changelog Entry
For release notes:
Alternatives
We could also ...
Test coverage
Context
Related links, screenshot before/after, video