px_uploader.py: try to follow PEP8 #6278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some non-Pythonic things and unneccessary semicolons. Still to fix are line-length and multiple spaces before operators.
julianoes
force-pushed
the
fix_uploader
branch
from
42d2341
to
4615c81
Compare
bkueng
approved these changes
Jan 9, 2017
|
Tested on macOS 10.11, works as well. |
|
Was this done manually or with a script? |
|
@dagar: manually |
|
We could run all of the python scripts through autopep8 or something, but I'd guess the change would be massive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some non-Pythonic things and unneccessary semicolons.
Still to fix are line-length and multiple spaces before operators.