New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic config: add actuators page (replacing motors) #1704
Conversation
A trim value can be configured for control surfaces, which is also applied to the test slider. | ||
::: | ||
|
||
Note the following behaviour: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we perhaps have at least some of this stuff first as safety warnings before the guidance? e.g. kill switch, safety button, and perhaps removing props?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we could. Although the switch in the UI already says it.
@bkueng Good start. Some questions in line which will help me nitpick a bit more.
My main concern is that it isn't quite clear how much of this you have to do for what airframe. It's a bit like the tuning stuff - we used to say you can just fly a matching airframe without "having" to do this. Now it sounds like we might be having fewer airframes and we expect people to do this. |
Assigning the outputs will be the main (and only) change for the user, if it's not an exotic one. I still forsee that we have generic airframes for different MC types (i.e. quad, hexa, coax, ...), where the geometry is preconfigured appropriately. |
aede648
to
96b1465
Compare
en/config/actuators.md
Outdated
|
||
The sliders snap into place at the lower end, and motors are turned off (disarmed). | ||
The "minimum thrust" position is the next slider position, which commands the minimum thrust. | ||
Adjust the minimum output value such that the motors spin at that slider position. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we do this? On this screen we can configure max/min value for some servos but not for motors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can mention that this is mostly relevant when PWM is used. For DShot it's not required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add that, but can you confirm that, for PWM, this is something you have to do outside of this screen/configuration? i wonder if we should provide PWM range setting controls for motors using PWM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, min/max will show up if you have PWM selected (as in the screenshot), and only be hidden if DShot is selected.
![Tilt Axis](../../assets/config/actuators/tilt_axis.png) | ||
|
||
|
||
### Bidirectional Motors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkueng Note, I have updated this section from reversible to bidirectional motors. Why? Because we were also using reversible to mean a motor that can configure to go in either direction (but not switch while in use)
Do you think perhaps we could also change QGC to use the term "bidirectional"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkueng Did you see this? Are you otherwise good for this to merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes bidirectional is fine.
- instead of 'required', can you use something like 'you have the option to...'? Even for rovers you don't need it, if you don't care about only going forwards.
the option will only be displayed if relevant for the frame type
-> you always have the option under 'advanced'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes bidirectional is fine.
It would be even better if you changed it in QGC :-).
I've added as (accepted) suggestions below. Note that when I pressed advanced checkbox in Sim last time I did not see the reversible option, which is why I assumed this is a feature of the airframe. Nevertheless I'll assume the sim is incorrect, not the intent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already in the pipeline: PX4/PX4-Autopilot@d23b5fd :-)
Hmm did you check on the geometry side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some comments above, but I think this is probably OK to go in now. We can update again when FW and VTOL are fully supported or when control allocation is fully enabled. Let me know if you want me to merge or not. |
@bkueng This is good initial docs for now. Thanks. Merging. |
Initial docs for dynamic control allocation, containing tips and conventions on how to use the new UI (mavlink/qgroundcontrol#9952).