Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for R1 SDF https://github.com/PX4/sitl_gazebo/issues/533 #534

Merged
merged 3 commits into from Jun 25, 2020
Merged

fixes for R1 SDF https://github.com/PX4/sitl_gazebo/issues/533 #534

merged 3 commits into from Jun 25, 2020

Conversation

bperseghetti
Copy link
Member

Fixes for R1 that also requires PR for Firmware: PX4/PX4-Autopilot#15209 to work fully.
Fixes issues brought up in #533

@bperseghetti bperseghetti mentioned this pull request Jun 24, 2020
Closed
Jaeyoung-Lim
Jaeyoung-Lim requested changes Jun 24, 2020
View reviewed changes
models/r1_rover/r1_rover.sdf Outdated Show resolved Hide resolved
models/r1_rover/r1_rover.sdf Outdated Show resolved Hide resolved
@Jaeyoung-Lim
Copy link
Member

Jaeyoung-Lim commented Jun 24, 2020 •
edited

@bperseghetti Thanks for getting this working! How are you testing this?

While testing this PR, I noticed that the gps position is not valid in this model anymore, probably because #517 wasn't ported to this model probably. Are you only testing in manual mode with the joysticks?

@TSC21
Copy link
Member

TSC21 commented Jun 24, 2020

@bperseghetti Thanks for getting this working! How are you testing this?

While testing this PR, I noticed that the gps position is not valid in this model anymore, probably because #517 wasn't ported to this model probably. Are you only testing in manual mode with the joysticks?

Yes it was https://github.com/PX4/sitl_gazebo/pull/517/files

@Jaeyoung-Lim
Copy link
Member

@TSC21 Ah, sorry. @bperseghetti I guess this means this PR needs a rebase on the latest master

@bperseghetti
Copy link
Member Author

@Jaeyoung-Lim @TSC21 here: 34fe131

Jaeyoung-Lim
Jaeyoung-Lim approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tested locally, and is a huge improvement in controls!

Mission mode is still not working, but should be fixed on the firmware side.

The sdf validation is failing on https://travis-ci.org/github/PX4/sitl_gazebo/jobs/701776596#L234

@Jaeyoung-Lim
Copy link
Member

Jaeyoung-Lim commented Jun 25, 2020 •
edited

Fixes #533

@TSC21 What would be your take on the sdf schema validation? It seems that the sdf schema isn't being updated anymore

@Jaeyoung-Lim Jaeyoung-Lim merged commit 5e8ddfb into PX4:master Jun 25, 2020
@Jaeyoung-Lim Jaeyoung-Lim mentioned this pull request Jun 25, 2020
Merged
RyosukeMatsushima pushed a commit to RyosukeMatsushima/PX4-SITL_gazebo that referenced this pull request Jun 21, 2022
@bperseghetti
fixes for R1 SDF PX4#533 (PX4#534)
da1893e 
* fixes for R1 SDF PX4#533

* fix 1.7 to 1.6 for anyone stuck on gazebo 9 and fix ode param typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaeyoung-Lim Jaeyoung-Lim Jaeyoung-Lim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bperseghetti @Jaeyoung-Lim @TSC21