Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add newline and indentation for too long lines #52

Closed
PabloRMira opened this issue Dec 18, 2020 · 1 comment · Fixed by #148
Closed

[FEA] Add newline and indentation for too long lines #52

PabloRMira opened this issue Dec 18, 2020 · 1 comment · Fixed by #148
Assignees
@PabloRMira
Labels
enhancement New feature or request new feature New feature

Comments

@PabloRMira
Copy link
Owner

Kind of reformatting afterwards

Specially useful for SELECT and ON lines
@PabloRMira PabloRMira added the new feature New feature label Dec 18, 2020
@PabloRMira PabloRMira self-assigned this Dec 18, 2020
@PabloRMira PabloRMira added the enhancement New feature or request label Dec 18, 2020
@PabloRMira
Copy link
Owner Author

Some ideas:

maybe based on some config file like on pyproject.toml or .sql_formatter

and then something in there like

[sql_formatter]
max_line_length = 88

For case when we can split after and or or

This should be done at the end of format_simple_sql maybe within a reformat_statements() function

@PabloRMira PabloRMira mentioned this issue Dec 25, 2020
Closed
@PabloRMira PabloRMira mentioned this issue Mar 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PabloRMira PabloRMira

Labels
enhancement New feature or request new feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEA] Add newline and indentation for too long lines PabloRMira/sql_formatter
1 participant
@PabloRMira