Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define command time unit parsing #121

Open
bramz opened this issue Mar 22, 2019 · 0 comments
Open

Define command time unit parsing #121

bramz opened this issue Mar 22, 2019 · 0 comments
Labels
bug Something isn't working command new command integration enhancement New feature or request

Comments

@bramz
Copy link
Contributor

bramz commented Mar 22, 2019

Reduce the long if/else statement and address a bug pertaining to max time lengths. A max integer size is required here in order to prevent time integer overflow. To easily reduce, accepting unit abbreviation only, would allow us to simplify. I do, however, prefer multiple unit support.

@bramz bramz added bug Something isn't working enhancement New feature or request command new command integration labels Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working command new command integration enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant