-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoNLP]add visualdl #4990
[AutoNLP]add visualdl #4990
Conversation
Thanks for your contribution! |
Codecov Report
@@ Coverage Diff @@
## develop #4990 +/- ##
===========================================
- Coverage 47.58% 47.57% -0.01%
===========================================
Files 453 453
Lines 65378 65385 +7
===========================================
Hits 31109 31109
- Misses 34269 34276 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议先研究清楚ai studio里的vdl功能是怎么工作的,在写这个PR
@@ -642,3 +644,10 @@ def export(self, export_path, trial_id=None): | |||
|
|||
logger.info(f"Exported {trial_id} to {export_path}") | |||
return taskflow_config | |||
|
|||
def visualdl(self, trial_id: Optional[str] = None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个应该写到auto_trainer_base.py里面作为后续所有任务的共有函数
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改写到共有函数
@@ -112,7 +112,7 @@ def on_log(self, args, state, control, logs=None, **kwargs): | |||
return | |||
|
|||
if self.vdl_writer is None: | |||
self._init_summary_writer(args) | |||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trainer里evaluate调用log函数的时候会新增一个visualdl的log文件。
这块修改需要 @ZHUI 确认是否没问题
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我这里lgtm. 看 @ZHUI 怎么说
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
New features
PR changes
APIs
Description
新增返回visualdl路径