[Fix]Make sure the args tb_writer passed to the TensorBoardCallback works #13636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add an
if
check in theon_train_begin
function of theTensorBoardCallback
, to make sure the argstb_writer
passed to the__init__
won't be overwritten.I wanted to pass a tb_writer to the
TensorBoardCallback
, so that I could continue using it after training. But the passed tb_writer didn't work.After checking the code of
TensorBoardCallback
, I found that the tb_writer passed to the__init__
would be overwritten by theon_train_begin
function with a new one no matter what.By adding an
if
statement before the init, this bug should be fixed.Before submitting
This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
Did you read the contributor guideline,
Pull Request section?
Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
Add option to keep tb_writer open after training is done. #5329 (a similar issue but is "wontfix" and out-of-date)
Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
Did you write any new necessary tests?
Who can review?
@sgugger