Fix dagre-d3 require issue (#359)

PaddlePaddle · Apr 4, 2018 · e4018d1 · e4018d1
1 parent 4a0511d
commit e4018d1
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 5 deletions.
diff --git a/frontend/package.json b/frontend/package.json
@@ -19,7 +19,6 @@
     "d3": "^4.7.4",
     "d3-format": "^1.2.1",
     "dagre": "^0.8.2",
-    "dagre-d3": "^0.6.1",
     "echarts": "^4.0.0",
     "echarts-gl": "^1.1.0",
     "file-saver": "^1.3.3",

diff --git a/frontend/src/graph/ui/Chart.vue b/frontend/src/graph/ui/Chart.vue
@@ -22,7 +22,6 @@
     // for d3 drawing
     import * as d3 from "d3";
     import * as dagre from "dagre";
-    import * as dagreD3 from 'dagre-d3';
 
     export default {
         props: ['fitScreen', 'download', 'scale', 'curNode'],

diff --git a/frontend/template/index.html b/frontend/template/index.html
@@ -6,6 +6,7 @@
         <meta name="viewport" content="width=device-width, initial-scale=1">
         <meta http-equiv="X-UA-Compatible" content="IE=Edge">
         <link href='https://fonts.googleapis.com/css?family=Roboto:300,400,500,700|Material+Icons' rel="stylesheet">
+        <script src="https://dagrejs.github.io/project/dagre-d3/latest/dagre-d3.min.js"></script>
     </head>
     <body>
         <div id="root"></div>

diff --git a/frontend/tool/webpack.config.js b/frontend/tool/webpack.config.js
@@ -123,7 +123,10 @@ const config = {
             test: /\.(styl)$/
         }),
         new ExtractTextPlugin({filename: '[name].css'})
-    ]
+    ],
+    externals: {
+        dagreD3: 'dagre-d3'
+    }
 };
 
 // template config

diff --git a/visualdl/logic/sdk.h b/visualdl/logic/sdk.h
@@ -440,8 +440,8 @@ struct Audio {
 };
 
 /*
-* Audio reader.
-*/
+ * Audio reader.
+ */
 struct AudioReader {
   using value_t = typename Audio::value_t;