failed to create an incident

[chunyanlv]

Here is my code:

        opts := officialPD.CreateIncidentOptions{
                Type: "incident",
                Title: title,
                Service: &service,
                Body: &body,
                EscalationPolicy: &escalationPolicy,
        }
 _, err := client.CreateIncident(INCIDENT_FROM, &opts)

I have the title correctly set.
But I got the error like:

panic: Failed call API endpoint. HTTP response code: 400. Error: &{2001 Invalid Input Provided [Title cannot be empty.]}

Does anyone know what is wrong?

[joepurdy]

Looks like a bug in the implementation of CreateIncident

func (c *Client) CreateIncident(from string, o *CreateIncidentOptions) (*Incident, error) {
	headers := make(map[string]string)
	headers["From"] = from
	resp, e := c.post("/incidents", o, &headers)
        .....
}

This is a bit different than other implementations, for example consider CreateIncidentNote:

func (c *Client) CreateIncidentNote(id string, note IncidentNote) error {
	data := make(map[string]IncidentNote)
	headers := make(map[string]string)
	headers["From"] = note.User.Summary

	data["note"] = note
	_, err := c.post("/incidents/"+id+"/notes", data, &headers)
	return err
}

The difference is that with CreateIncident the options are being passed directly as-is. Other places the options get placed under a named property like data["note"] = note

I'll open a PR with the fix shortly.

[snaveen]

I saw your fix. It would be really helpful for me if this gets merged. Is there any workaround till that?

[joepurdy]

@snaveen My PR being merged is up to the maintainers of PagerDuty/go-pagerduty

If you want to use my fork for the time being I've gone and merged my fix into master there: https://github.com/joepurdy/go-pagerduty

I'll do my best to keep the fork updated with upstream, but ultimately the best fix would be the maintainers merging the fix into upstream.

[snaveen]

Thanks @joepurdy

[theckman]

I think I have merge access, let me see if I can do the needful tonight (Pacific time).

[snaveen]

@theckman could you help us on this?

[snaveen]

@ranjib Could you help us on this?