Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: EU Data Location support for Events API #355

Closed
solita-mikatormanen opened this issue Aug 30, 2021 · 2 comments
Closed
Labels

Comments

@solita-mikatormanen
Copy link

Hi

As Pagerduty extended their support for also EU Data Location, would there be some kind of schedule for the library to support EU endpoints also?

@theckman
Copy link
Collaborator

theckman commented Aug 30, 2021

Hello,

There isn't a schedule for that, no. I am the primary maintainer of this package, and because I am not a PagerDuty employee I do this on my personal time. This is also the first time I've heard of that feature, it isn't something I would personally use, and there's already substantial amount of work I have queued-up for the upcoming v1.5.0 release.

If you'd be able to raise a PR, and be on-deck to address any feedback, I'd likely be able to make some time to review it fairly quickly and merge when ready.

@theckman
Copy link
Collaborator

theckman commented Sep 5, 2021

@solita-mikatormanen Actually, it looks like we already implicitly do:

https://pkg.go.dev/github.com/PagerDuty/go-pagerduty#WithAPIEndpoint
https://pkg.go.dev/github.com/PagerDuty/go-pagerduty#WithV2EventsAPIEndpoint

If you find anything in particular we need to change or implement, could you please open an issue specific to that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants