Ignore data validation and conditional format flags #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mance of range insertion. DV and CF are handled elsewhere.
igitur
force-pushed
the
pr1029-pankraty-1026_CellsUsedFix
branch
from
047626a
to
79bd47b
Compare
|
If you agree, rebase, not merge please. |
|
This looks fine but I thought about improving FirstCellUsed and LastCellUsed too. Now they get all used cells and then calculate minimum (or maximum) row and column. Instead, they should get all used cells excluding ConditionalFormats and DataValidation, and then, if these flags are specified, check first (or last) cells of all ranges among CFs and DVs. This should fix the issue with the slow test too. |
|
Yes, I looked into that too, but that's going to be a much larger refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore data validation and conditional format flags to improve performance of range insertion.
DV and CF are handled elsewhere.
This fixes the long running
CFShiftedTruncateRangeandDataValidationShiftedTruncateRangetests.