Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash give item NBT tag #1523

Closed
splintermik opened this issue Oct 2, 2018 · 3 comments
Closed

Crash give item NBT tag #1523

splintermik opened this issue Oct 2, 2018 · 3 comments
Assignees
Labels
type: bug Something doesn't work as it was intended to.

Comments

@splintermik
Copy link

Hello, I encountered a bug

when I give myself an object with an NBT tags, it crashes the game ( I test it solo, and no crash)

the typing command is as follows:
/give @A minecraft:diamond_sword{HideFlags:63,CanDestroy:["yellow_flower", "red_flower", "tallgrass", "ladder"]} 1

here's what it says in the logs:

[22:42:42] [Server thread/INFO]: splintermik issued server command: /give @A minecraft:diamond_sword{HideFlags:63,CanDestroy:["yellow_flower", "red_flower", "tallgrass", "ladder"]} 1
[22:42:42] [Netty Server IO #1/ERROR]: java.lang.NullPointerException
[22:42:42] [Server thread/INFO]: splintermik lost connection: Internal Exception: io.netty.handler.codec.EncoderException: java.lang.NullPointerException
[22:42:42] [Server thread/INFO]: splintermik left the game
[22:42:47] [User Authenticator #2/INFO]: UUID of player splintermik is f05b0e69-bb5b-3ba1-b331-8d5835f6bb62
[22:42:47] [Server thread/INFO]: splintermik[/127.0.0.1:60753] logged in with entity id 42 at ([MONDE]1234.9828372050413, 29.489191728492088, 195.27331192350096)
[22:42:47] [Netty Server IO #2/ERROR]: java.lang.NullPointerException
[22:42:47] [Netty Server IO #2/ERROR]: java.lang.NullPointerException
[22:42:47] [Server thread/INFO]: splintermik lost connection: Internal Exception: io.netty.handler.codec.EncoderException: java.lang.NullPointerException
[22:42:47] [Server thread/INFO]: splintermik left the game

paper version : Paper version git-Paper-324 (MC: 1.13.1) (Implementing API version 1.13.1-R0.1-SNAPSHOT)

plugin : 0

Here, I don't know if it's a bug already reported.

thank you :)

@zachbr zachbr self-assigned this Oct 3, 2018
@zachbr zachbr added the type: bug Something doesn't work as it was intended to. label Oct 3, 2018
@zachbr
Copy link
Contributor

zachbr commented Oct 3, 2018

After some testing this appears to be a result of 3491f55

@zachbr zachbr closed this as completed in 10209bf Oct 3, 2018
@zachbr
Copy link
Contributor

zachbr commented Oct 3, 2018

Our handling of null items (that can't be found in Minecraft's item namespace) was wrong. Your command references red_flower, tallgrass, and yellow_flower none of which exist.
They're actually poppy, tall_grass, and dandelion respectively.

Paper will now handle these cases better but you should note that your command was probably wrong (unless vanilla MC accepts these and they work, in which case we have some additional item matching to do).

Thanks for letting us know, fixed in builds 326+

@splintermik
Copy link
Author

I just tested on the server version proposed by mojang

the order does not crash the game on the customer side

but the following tags don't work: yellow_flower, red_flower, tallgrass

thank you very much for the update! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something doesn't work as it was intended to.
Projects
None yet
Development

No branches or pull requests

2 participants