Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorldGuardExtender plugin error #17

Closed
FunnyCraft opened this issue Feb 6, 2016 · 3 comments
Closed

WorldGuardExtender plugin error #17

FunnyCraft opened this issue Feb 6, 2016 · 3 comments
Labels
resolution: won't fix Issue will not be resolved or feature not added.

Comments

@FunnyCraft
Copy link

Hello, after updating PaperSpigot, stopped working WorldGuard, please correct.
Screenshot http://ssmaker.ru/ec6a85f2/

@zachbr zachbr added the resolution: cannot reproduce Paper team is unable to replicate the issue. label Feb 7, 2016
@FunnyCraft
Copy link
Author

@FunnyCraft
Copy link
Author

http://build.true-games.org/job/WorldGuardExtender/
The idea of a conflict with this plugin.

@zachbr zachbr added resolution: won't fix Issue will not be resolved or feature not added. and removed resolution: cannot reproduce Paper team is unable to replicate the issue. labels Feb 11, 2016
@zachbr
Copy link
Contributor

zachbr commented Feb 12, 2016

As so eloquently explained by @aikar:

[17:50:41] < Aikar > thats a bug in their plugin
[17:50:58] < Aikar > they should be calling commandMap.register(command), not command.register(commandmap)
[17:51:13] < Aikar > they are shortcutting process
[17:51:46] < Aikar > and im surprised that shit even works. command.register(commandmap) doesnt even insert the command into the command map

[17:54:20] < Aikar > i mean i guess you could tech fix it in paper
[17:54:29] < Aikar > SimpleCommandMap register
[17:54:33] < Aikar > we do timings = there
[17:54:41] < Aikar > can move that code down to the command.register
[17:56:21] < Aikar > but then if a ny plugin ever overloads registerPlugin on the command.... same issue
[17:56:48] < Aikar > register*

This is something that plugin should fix, we will not go out of our way to fix this one use-case for a broken plugin doing hacky things (and then our fix would break other things).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution: won't fix Issue will not be resolved or feature not added.
Projects
None yet
Development

No branches or pull requests

2 participants