Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Update Folder Implementation #6570

Closed
2 tasks done
Xemorr opened this issue Sep 6, 2021 · 2 comments
Closed
2 tasks done

Better Update Folder Implementation #6570

Xemorr opened this issue Sep 6, 2021 · 2 comments
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: feature Request for a new Feature.

Comments

@Xemorr
Copy link
Contributor

Xemorr commented Sep 6, 2021

Is your feature request related to a problem?

When using the update folder to update plugins, it only replaces a plugin if the file name is the same. This causes issues when trying to follow good convention and have versioned file names.

Describe the solution you'd like.

I would instead like it to replace a plugin if the plugin name (as stored in plugin.yml) is the same.

Describe alternatives you've considered.

Writing the PR myself but I don't think I'd do a good job.

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported Paper build.

Other

No response

@MiniDigger
Copy link
Member

"I don't think I'd do a good job"

just give it a try! we are always happy to help, join the #paper-dev channel on discord if you need any assistance and people will be happy to help

@Xemorr
Copy link
Contributor Author

Xemorr commented Sep 7, 2021

Yeah, alright, I'll give it a go.

@e-im e-im added the type: feature Request for a new Feature. label Sep 7, 2021
@Chew Chew added the status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. label Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: feature Request for a new Feature.
Projects
None yet
Development

No branches or pull requests

5 participants