Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to modify life/lifetime of a firework entity #7433

Closed
kezz opened this issue Feb 2, 2022 · 0 comments · Fixed by #5731
Closed

Ability to modify life/lifetime of a firework entity #7433

kezz opened this issue Feb 2, 2022 · 0 comments · Fixed by #5731
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: feature Request for a new Feature.

Comments

@kezz
Copy link
Contributor

kezz commented Feb 2, 2022

Is your feature request related to a problem?

There is currently no way with the API to set the life time (ticks until it explodes) or the life (current number of ticks it's been active for) of a firework. These are represented by the backing ints life and lifetime in FireworkRocketEntity, meaning this should be a relatively easy feature addition.

Describe the solution you'd like.

New methods to get/set the life and lifetime (probably with better words than those) of a firework entity.

Describe alternatives you've considered.

It's possible to do this by grabbing the handle and setting the lifetime, although changing the life is not possible without yucky reflection.

Other

No response

@kezz kezz added status: needs triage type: feature Request for a new Feature. labels Feb 2, 2022
@kennytv kennytv linked a pull request Feb 2, 2022 that will close this issue
@Chew Chew added status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. and removed status: needs triage labels Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: feature Request for a new Feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants