Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.19] Configuration Migration Issues #7913

Closed
e-im opened this issue Jun 9, 2022 · 47 comments
Closed

[1.19] Configuration Migration Issues #7913

e-im opened this issue Jun 9, 2022 · 47 comments
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: bug Something doesn't work as it was intended to. version: 1.19 Game version 1.19

Comments

@e-im
Copy link
Contributor

e-im commented Jun 9, 2022 •
edited
Loading

Please put all 1.19 configuration migration related issues as comments on this thread. Known issues will be added here.

Known issues:
@e-im e-im added type: bug Something doesn't work as it was intended to. status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. version: 1.19 Game version 1.19 labels Jun 9, 2022
@AnthraxHost

This comment was marked as off-topic.

Sign in to view
@electronicboy

This comment was marked as off-topic.

Sign in to view
@e-im

This comment was marked as off-topic.

Sign in to view
@AnthraxHost

This comment was marked as off-topic.

Sign in to view
@Blzd87

This comment was marked as off-topic.

Sign in to view
@e-im

This comment was marked as off-topic.

Sign in to view
@Folas1337
Copy link

Since I seem to have had some errors, just for completion here's my paper.yml I had before: https://paste.gg/p/anonymous/ac947dd04450483f886cbafbd9c1ecea

Several settings weren't copied including the velocity-support section, anti-xray, entity-per-chunk-save-limit, max-auto-save-chunks-per-tick and a lot more that I didn't check yet.

I still have to verify it with experimental build 2 once it's working :)

@Machine-Maker
Copy link
Member

@Folas1337 please post any stacktraces that may have appeared in the logs. I just ran your config through the migration and I see the velocity section (it moved, search for velocity), I see anti-xray (in paper-world-defaults.yml). Please make sure the settings you are talking about are acutally missing, and not just renamed. TONS of settings were renamed, put in different places etc. I see entity-per-chunk-save-limit in paper-world-defaults.yml for example.

@Folas1337

This comment was marked as resolved.

Sign in to view
@Machine-Maker
Copy link
Member

Machine-Maker commented Jun 10, 2022 •
edited
Loading

@Folas1337 are you sure? look inside the world folders. I specifically checked for that too. Like I saw the antixray settings for world_survival_nether and world_survival_the_end

@Folas1337
Copy link

Ah alright, I take that one back, totally missed they're in the world folders. Thanks for clarifying, the other 3 are still valid though.
I am sure about those :)

@Machine-Maker
Copy link
Member

Machine-Maker commented Jun 10, 2022 •
edited
Loading

Ok, async-chunks.threads being set away from -1 is a bug, and the alt-item-despawn-rate enabled being flipped is too. the 2nd one tho is supposed to happen. -1 was the default before.

EDIT: @Folas1337 both of those issues should be resolved when the next build is posted.

@Blzd87

This comment was marked as off-topic.

Sign in to view
@aurorasmiles

This comment was marked as off-topic.

Sign in to view
@SirKillian
Copy link

After trying experimental 4, one out of my six worlds did not convert properly.

My backup file paper.yml.old shows:

world-settings:
  Spawn:
    keep-spawn-loaded-range: 6
    keep-spawn-loaded: true

But my paper-world.yml in my Spawn directory shows:

# This is a world configuration file for Paper.
# This file may start empty but can be filled with settings to override ones in the config/world-defaults.yml

_version: 28

No console errors so I'm not sure if this report is helpful in the first place.

@nopjar

This comment was marked as resolved.

Sign in to view
@Strahilchu

This comment was marked as off-topic.

Sign in to view
@Blzd87

This comment was marked as outdated.

Sign in to view
@Machine-Maker
Copy link
Member

That log doesn't help at all. Please provide the latest.log instead of the crash report.

@heychazza

This comment was marked as off-topic.

Sign in to view
@Machine-Maker
Copy link
Member

Use the latest experimental build, build 5 @heychazza

@Folas1337
Copy link

Folas1337 commented Jun 10, 2022 •
edited
Loading

I've verified with build 5 and can't find any errors anymore.
What I haven't verified though is that there wasn't any configuration missed entirely, I only looked in the new file and checked if all the settings that are present there had the same values as in the old config.

If any configs were missing in the new file entirely I wouldn't have noticed. Might check that later... maybe someone else does before me, then feel free to report :)

@heychazza

This comment was marked as off-topic.

Sign in to view
@Folas1337

This comment was marked as off-topic.

Sign in to view
@Machine-Maker
Copy link
Member

@SirKillian can you post your full paper.yml? There should've been a backup made of it. I can't seem to replicate your issue. Setting server.properties level-name=Spawn and adding those 2 lines to a default 1.18.2 config works fine. They show up in the Spawn folder's config file in the right place.

@SirKillian
Copy link

@SirKillian can you post your full paper.yml?

@Machine-Maker https://paste.helpch.at/ixucigoyiv.yml

@nopjar
Copy link
Contributor

nopjar commented Jun 10, 2022

Still getting the server crash on startup with experimental v5. Log: https://pastebin.pl/view/574f1a77

@Machine-Maker Machine-Maker mentioned this issue Jun 10, 2022
Merged
@nopjar
Copy link
Contributor

nopjar commented Jun 10, 2022

Still getting the server crash on startup with experimental v5. Log: https://pastebin.pl/view/574f1a77

Just to give you an update: This issue is not caused by paper! There existed a file in the directory which was called config.

@e-im e-im mentioned this issue Jun 10, 2022
Closed
@e-im

This comment was marked as resolved.

Sign in to view
@Blzd87

This comment was marked as off-topic.

Sign in to view
@Machine-Maker
Copy link
Member

Missing entity types under despawn-ranges causes the server to crash after world load (#7935)

[22:30:49 ERROR]: Encountered an unexpected exception
net.minecraft.ReportedException: Exception ticking world
	at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1570) ~[paper-1.19.jar:git-Paper-"9b6fb2f"]
	at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:446) ~[paper-1.19.jar:git-Paper-"9b6fb2f"]
	at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1414) ~[paper-1.19.jar:git-Paper-"9b6fb2f"]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1187) ~[paper-1.19.jar:git-Paper-"9b6fb2f"]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:302) ~[paper-1.19.jar:git-Paper-"9b6fb2f"]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.lang.NullPointerException: Cannot invoke "io.papermc.paper.configuration.WorldConfiguration$Entities$Spawning$DespawnRange.hard()" because the return value of "java.util.Map.get(Object)" is null
	at net.minecraft.world.entity.Mob.checkDespawn(Mob.java:806) ~[?:?]
	at net.minecraft.server.level.ServerLevel.lambda$tick$6(ServerLevel.java:678) ~[?:?]
	at net.minecraft.world.level.entity.EntityTickList.forEach(EntityTickList.java:42) ~[paper-1.19.jar:git-Paper-"9b6fb2f"]
	at net.minecraft.server.level.ServerLevel.tick(ServerLevel.java:672) ~[?:?]
	at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1551) ~[paper-1.19.jar:git-Paper-"9b6fb2f"]
	... 5 more

Resolved in 76f81ae

@IntroCDC

This comment was marked as off-topic.

Sign in to view
@sovtec

This comment was marked as off-topic.

Sign in to view
@Owen1212055

This comment was marked as off-topic.

Sign in to view
@kennytv kennytv reopened this Jun 11, 2022
@Codzsters

This comment was marked as resolved.

Sign in to view
@kennytv

This comment was marked as resolved.

Sign in to view
@Codzsters

This comment was marked as resolved.

Sign in to view
@kennytv

This comment was marked as resolved.

Sign in to view
@alezhshede

This comment was marked as resolved.

Sign in to view
@kennytv

This comment was marked as resolved.

Sign in to view
@alezhshede

This comment was marked as resolved.

Sign in to view
@surfrock66
Copy link

Certain fields which were configured previously as maps (and were working) are causing my server to not start, as it is looking for lists. Per the discussion on the paper forums, the 1.18.2 config was likely "invalid" but as it worked there and did not work in 1.19 after the config conversion, the experience was confusing. Maybe it can be a case where "lists" defined as "maps" could be converted as part of the conversion?

The issue is resolved by changing "{}" to "[]" in the config files.

Server error log:

[20:46:20 ERROR]: Encountered an unexpected exception
org.spongepowered.configurate.serialize.SerializationException: [anticheat, anti-xray, hidden-blocks] of type java.lang.String: Value must be provided as a scalar!
    at org.spongepowered.configurate.serialize.ScalarSerializer.deserialize(ScalarSerializer.java:101) ~[configurate-core-4.1.2.jar:?]
    at org.spongepowered.configurate.serialize.AbstractListChildSerializer.deserialize(AbstractListChildSerializer.java:69) ~[configurate-core-4.1.2.jar:?]
    at org.spongepowered.configurate.objectmapping.ObjectMapperImpl.load0(ObjectMapperImpl.java:64) ~[configurate-core-4.1.2.jar:?]
    at org.spongepowered.configurate.objectmapping.ObjectMapperImpl.load(ObjectMapperImpl.java:48) ~[configurate-core-4.1.2.jar:?]
    at org.spongepowered.configurate.objectmapping.ObjectMapperFactoryImpl.deserialize(ObjectMapperFactoryImpl.java:204) ~[configurate-core-4.1.2.jar:?]
    at org.spongepowered.configurate.objectmapping.ObjectMapperImpl.load0(ObjectMapperImpl.java:64) ~[configurate-core-4.1.2.jar:?]
    at org.spongepowered.configurate.objectmapping.ObjectMapperImpl.load(ObjectMapperImpl.java:48) ~[configurate-core-4.1.2.jar:?]
    at org.spongepowered.configurate.objectmapping.ObjectMapperFactoryImpl.deserialize(ObjectMapperFactoryImpl.java:204) ~[configurate-core-4.1.2.jar:?]
    at org.spongepowered.configurate.objectmapping.ObjectMapperImpl.load0(ObjectMapperImpl.java:64) ~[configurate-core-4.1.2.jar:?]
    at org.spongepowered.configurate.objectmapping.ObjectMapperImpl.load(ObjectMapperImpl.java:48) ~[configurate-core-4.1.2.jar:?]
    at org.spongepowered.configurate.objectmapping.ObjectMapperFactoryImpl.deserialize(ObjectMapperFactoryImpl.java:204) ~[configurate-core-4.1.2.jar:?]
    at org.spongepowered.configurate.AbstractConfigurationNode.get(AbstractConfigurationNode.java:151) ~[configurate-core-4.1.2.jar:?]
    at org.spongepowered.configurate.ConfigurationNode.get(ConfigurationNode.java:520) ~[configurate-core-4.1.2.jar:?]
    at org.spongepowered.configurate.ConfigurationNode.require(ConfigurationNode.java:407) ~[configurate-core-4.1.2.jar:?]
    at io.papermc.paper.configuration.Configurations.initializeWorldDefaultsConfiguration(Configurations.java:139) ~[paper-1.19.jar:git-Paper-"d1b1c6f"]
    at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:221) ~[paper-1.19.jar:git-Paper-"d1b1c6f"]
    at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1121) ~[paper-1.19.jar:git-Paper-"d1b1c6f"]
    at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:302) ~[paper-1.19.jar:git-Paper-"d1b1c6f"]
    at java.lang.Thread.run(Thread.java:833) ~[?:?]
    Suppressed: org.spongepowered.configurate.serialize.SerializationException: [anticheat, anti-xray, replacement-blocks] of type java.lang.String: Value must be provided as a scalar!
        at org.spongepowered.configurate.serialize.ScalarSerializer.deserialize(ScalarSerializer.java:101) ~[configurate-core-4.1.2.jar:?]
        at org.spongepowered.configurate.serialize.AbstractListChildSerializer.deserialize(AbstractListChildSerializer.java:69) ~[configurate-core-4.1.2.jar:?]
        at org.spongepowered.configurate.objectmapping.ObjectMapperImpl.load0(ObjectMapperImpl.java:64) ~[configurate-core-4.1.2.jar:?]
        at org.spongepowered.configurate.objectmapping.ObjectMapperImpl.load(ObjectMapperImpl.java:48) ~[configurate-core-4.1.2.jar:?]
        at org.spongepowered.configurate.objectmapping.ObjectMapperFactoryImpl.deserialize(ObjectMapperFactoryImpl.java:204) ~[configurate-core-4.1.2.jar:?]
        at org.spongepowered.configurate.objectmapping.ObjectMapperImpl.load0(ObjectMapperImpl.java:64) ~[configurate-core-4.1.2.jar:?]
        at org.spongepowered.configurate.objectmapping.ObjectMapperImpl.load(ObjectMapperImpl.java:48) ~[configurate-core-4.1.2.jar:?]
        at org.spongepowered.configurate.objectmapping.ObjectMapperFactoryImpl.deserialize(ObjectMapperFactoryImpl.java:204) ~[configurate-core-4.1.2.jar:?]
        at org.spongepowered.configurate.objectmapping.ObjectMapperImpl.load0(ObjectMapperImpl.java:64) ~[configurate-core-4.1.2.jar:?]
        at org.spongepowered.configurate.objectmapping.ObjectMapperImpl.load(ObjectMapperImpl.java:48) ~[configurate-core-4.1.2.jar:?]
        at org.spongepowered.configurate.objectmapping.ObjectMapperFactoryImpl.deserialize(ObjectMapperFactoryImpl.java:204) ~[configurate-core-4.1.2.jar:?]
        at org.spongepowered.configurate.AbstractConfigurationNode.get(AbstractConfigurationNode.java:151) ~[configurate-core-4.1.2.jar:?]
        at org.spongepowered.configurate.ConfigurationNode.get(ConfigurationNode.java:520) ~[configurate-core-4.1.2.jar:?]
        at org.spongepowered.configurate.ConfigurationNode.require(ConfigurationNode.java:407) ~[configurate-core-4.1.2.jar:?]
        at io.papermc.paper.configuration.Configurations.initializeWorldDefaultsConfiguration(Configurations.java:139) ~[paper-1.19.jar:git-Paper-"d1b1c6f"]
        at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:221) ~[paper-1.19.jar:git-Paper-"d1b1c6f"]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1121) ~[paper-1.19.jar:git-Paper-"d1b1c6f"]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:302) ~[paper-1.19.jar:git-Paper-"d1b1c6f"]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]
[20:46:20 WARN]: Failed to get system info for World Generation
java.lang.NullPointerException: Cannot invoke "net.minecraft.world.level.storage.SaveData.B()" because "this.m" is null
    at net.minecraft.server.MinecraftServer.lambda$fillSystemReport$15(MinecraftServer.java:1692) ~[paper-1.19.jar:git-Paper-"d1b1c6f"]
    at net.minecraft.SystemReport.setDetail(SystemReport.java:61) ~[paper-1.19.jar:git-Paper-"d1b1c6f"]
    at net.minecraft.server.MinecraftServer.fillSystemReport(MinecraftServer.java:1691) ~[paper-1.19.jar:git-Paper-"d1b1c6f"]
    at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1213) ~[paper-1.19.jar:git-Paper-"d1b1c6f"]
    at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:302) ~[paper-1.19.jar:git-Paper-"d1b1c6f"]
    at java.lang.Thread.run(Thread.java:833) ~[?:?]

Full log file: https://paste.gg/p/anonymous/9dc3dabf6fc748e9836b194662f22e68/files/ab36129599384284b5a87cf30258f7a6/raw

Relevant section of 1.19 paper-world-defaults.yml:

anticheat:
  anti-xray:
    chunk-edge-mode: 3
    enabled: false
    engine-mode: 1
    hidden-blocks: {}
    lava-obscures: false
    max-block-height: 64
    max-chunk-section-index: 3
    replacement-blocks: {}
    update-radius: 2
    use-permission: false

1.18.2 paper.yml: https://paste.gg/p/anonymous/d54b1f2a0acb482cbfd4a9405795b670/files/e073226ec0d744fd8311c53b3903f11e/raw

I made a thread about this in the forum if the additional info is helpful: https://forums.papermc.io/threads/server-wont-start-compiled-from-the-latest-git-commit-currently-d1b1c6f.359/

@comonier

This comment was marked as off-topic.

Sign in to view
@electronicboy
Copy link
Member

Nothing to do with this issue, you already have something running on that port

@comonier

This comment was marked as off-topic.

Sign in to view
@aurorasmiles
Copy link
Contributor

Please go to our Discord for support. Your issue has nothing to do with what we are talking here

@electronicboy electronicboy pinned this issue Jun 26, 2022
@aurorasmiles
Copy link
Contributor

Since we didn't receive any other reports for over a month now, and all the known issues have been fixed, I'm closing this. If anyone else finds a config migration issue please open a new issue.

@aurorasmiles aurorasmiles unpinned this issue Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: bug Something doesn't work as it was intended to. version: 1.19 Game version 1.19
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests