Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghasts Teleporting through Nether Portals cause significantly more lag than other Entities. #9173

Closed
PoiiohPoii opened this issue Apr 30, 2023 · 15 comments
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: performance version: 1.19.4 Game version 1.19.4

Comments

@PoiiohPoii
Copy link

PoiiohPoii commented Apr 30, 2023

Timings or Profile link

https://spark.lucko.me/ooh5SoyreL

Description of issue

Ghasts that teleport through a nether portal cause significant amounts of lag.
Normally this does not occur under default paper settings.

Plugin and Datapack List

Spark

Server config files

(https://paste.gg/p/anonymous/775877fe088745df8d268f29027ac95d)

Paper version

This server is running Paper version git-Paper-521 (MC: 1.19.4) (Implementing API version 1.19.4-R0.1-SNAPSHOT) (Git: bcec5b1)
You are running the latest version
Previous version: git-Pufferfish-"f3011e9" (MC: 1.19.4)

Other

Seems to scale significantly as the server is put under more load.

Video of the lagspike happening on a superflat world, with an MSPT near 0: https://streamable.com/bszsx5

This also seems to be specific to ghasts. Cows, creepers & other mobs cause nearly no lag

@Pantera07
Copy link
Contributor

I've experienced the same issue as well.

@MCMDEV
Copy link
Contributor

MCMDEV commented May 7, 2023

Same here

@Pantera07
Copy link
Contributor

Ghast
Issue with Ghast's collision box size

@Teslicek
Copy link

Same here. Causing 400ms lag spikes with ghast farms.

@CatBang
Copy link

CatBang commented Jun 27, 2023

I'm also having this issue,1.20.1

@Potothingi
Copy link

I think the best solution is to add a configuration that skips the collision box size check if the entity moving through the portal is a Ghast.

@codebycam
Copy link

Hey @PoiiohPoii, can you please provide a new spark report?

@codebycam codebycam added the resolution: awaiting response Additional information is required from the issue reporter label Aug 24, 2023
@MCMDEV
Copy link
Contributor

MCMDEV commented Aug 29, 2023

@codebycam They're inactive now, but I administer the server this concerns.
Do you need a report for when the server is under load with players using ghast farms?

@lynxplay
Copy link
Contributor

We'd certainly be happy for more spark reports yea 👍

@Warriorrrr Warriorrrr added status: needs testing Issue needs verification. and removed resolution: awaiting response Additional information is required from the issue reporter status: needs triage labels Aug 30, 2023
@GoldenEdit
Copy link

https://spark.lucko.me/w27OFfDZub - On Linux

@Potothingi
Copy link

https://spark.lucko.me/w27OFfDZub - On Linux

1
"VoxelShape"

@Warriorrrr Warriorrrr added status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. and removed status: needs testing Issue needs verification. labels Sep 1, 2023
@codebycam
Copy link

codebycam commented Sep 2, 2023

Thanks for the info @GoldenEdit. We're aware of this issue and will hopefully be able to improve the performance around VoxelShape. Are you able to provide a zip of a world (or part of) with the farm you have please?

@GoldenEdit
Copy link

Thanks for the info @GoldenEdit. We're aware of this issue and will hopefully be able to improve the performance around VoxelShape. Are you able to provide a zip of a world (or part of) with the farm you have please?

When reproducing this I was only running a quick test by spawning Ghasts directly into the portal.

I may be able to provide you with a WorldEdit schematic of one of the farms on a server I manage, let me know if you would like that.

This issue happens anytime a ghast enters a nether portal, so any farm that uses an overworld killing chamber causes lag to servers.

@codebycam
Copy link

Thanks for the info @GoldenEdit. We're aware of this issue and will hopefully be able to improve the performance around VoxelShape. Are you able to provide a zip of a world (or part of) with the farm you have please?

When reproducing this I was only running a quick test by spawning Ghasts directly into the portal.

I may be able to provide you with a WorldEdit schematic of one of the farms on a server I manage, let me know if you would like that.

This issue happens anytime a ghast enters a nether portal, so any farm that uses an overworld killing chamber causes lag to servers.

Yeah that's fair enough, and I've been able to reproduce it with just the spawning into a portal too, but actually having a farm would be handy to test it. A schematic for the Overworld & Nether side would be fine too!

@Warriorrrr
Copy link
Member

Can no longer reproduce the large lag spike in 1.20.2 thanks to leaf's collision optimisations

@kashike kashike added the version: 1.19.4 Game version 1.19.4 label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: performance version: 1.19.4 Game version 1.19.4
Projects
None yet
Development

No branches or pull requests