Players get stuck in world border #9859
Comments
LaserSlime
added
status: needs triage
type: bug
Lulu13022002
added
status: accepted
|
Can reproduce, this is related to the other world border collision issue, the collision of the border is completely different on Paper. And this will trigger the following check: https://github.com/PaperMC/Paper/blob/master/patches/server/0728-Optimise-collision-checking-in-player-move-packet-ha.patch#L138 even for legit player |
|
Has happened to me too, It really makes it hard for us to use worldborders in minigames. |
True, I might try to fix this myself as no one from the core dev team seems to care about this since it's only relevant for minigames. |
|
The hope was that the patch maintainer would look into this, given that he generally knows this stuff much more closely than the rest of the team, given my lack of eye sight, this is not a high priority for me, but it's false to say we don't care. |
If you're gonna try to fix it yourself, I can give you more info about the bug |
That info being? |
|
For add a related bug if in survival worlds the portal generate in the border of worldborder the player is stuck in the portal and the worldborder like the video. |
|
Alright I've made a "fix" for this that simply ignores players when checking worldborder collision. I'm not sure if I should pr it since it's a rather suboptimal solution considering it allows people with cheats to just ignore the worldborder, but that is possible in vanilla/spigot too so idk. |
|
Happens to me as well, started occurring after I migrated from 1.20.1 to 1.20.4. It's a big issue for my minigames network. Considering reverting back to 1.20.1 just because of this one issue. |
Hey uhm how do you download this fix exactly? |
…33861b911a Fix incorrect border collision detection The epsilon used was in the opposite direction, which would cause the getCollisions method to incorrectly return it for when players were exactly on the border but not colliding. To bring it in-line with the rest of the collision code, the collision must be into the border by +EPSILON. Fixes PaperMC/Paper#9859
|
Issue still occurs when border is changing in size |
Could you perhaps show a video? |
|
|
Just noting that I can't replicate this in 1.20.4 Vanilla. Works fine: https://streamable.com/6jm35e |
|
Please re-try with 0b95298 |
Same issue. I figured out that the issue isn't just when the border is changing, it's also when it is partway through a block, instead of on the edge of one. e.g. on a non-even size. Video: https://youtu.be/LwjgORKxYEY |
The epsilon used was in the opposite direction, which would cause the getCollisions method to incorrectly return it for when players were exactly on the border but not colliding. To bring it in-line with the rest of the collision code, the collision must be into the border by +EPSILON. Fixes PaperMC#9859
…33861b911a Fix incorrect border collision detection The epsilon used was in the opposite direction, which would cause the getCollisions method to incorrectly return it for when players were exactly on the border but not colliding. To bring it in-line with the rest of the collision code, the collision must be into the border by +EPSILON. Fixes PaperMC/Paper#9859
Expected behavior
https://youtu.be/H6BfOt7zBjo
Observed/Actual behavior
https://youtu.be/IMQO19HYNnU
Steps/models to reproduce
Plugin and Datapack List
Server Plugins (0):
Paper version
This server is running Paper version git-Paper-243 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: 3a5c6f8)
Other
No response
The text was updated successfully, but these errors were encountered: