Send nearby packets from world list instead of server list #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mystiflow
changed the title
Mystiflow
force-pushed
the
send-from-world
branch
from
8f9daf1
to
f29f0df
Compare
|
This PR is ready for further review. I've addressed your issue above. Also I've expanded this PR to send nearby packets using the world field instead of dimension field as the predicator of which world to send the packets to. Previously they were sent by the same dimension;- so if there were 2 worlds with same dim in server - one player could send a packet to another in a parallel world (if they were within coords/nearby), which is incorrect.
|
Mystiflow
force-pushed
the
send-from-world
branch
from
f29f0df
to
cb1476f
Compare
No need to look in all servers
Also makes it so nearby packets are sent from the world and not
dimension. Because you can have two worlds with the same dimension in
the server and hearing things like attack sound packets from another
world in same dim is not ideal.
Mystiflow
force-pushed
the
send-from-world
branch
from
cb1476f
to
0e01cfa
Compare
mikroskeem
approved these changes
Aug 8, 2018
aikar
approved these changes
Aug 17, 2018
aikar
added a commit
that referenced
this pull request
Aug 19, 2018
* pre/1.13: (45 commits) [CI-SKIP] Remove old optimize hopper patch from removed Restore Optimized Hoppers patch [CI-SKIP] Remove some unneeded patches from removed folder restore vanilla default mob-spawn-range Fix some performance regression in last patch Don't iterate twice - Fixes GH-1346 Send nearby packets from world list instead of server list (#1196) [CI-SKIP] [Auto] Rebuild Patches 1.13: Player launch projectile event (#1249) Allow Blocks to be accessed via a long key (#1335) Optimize BlockPosition helper methods (#1339) Fix watchdog restarting on short timeout (#1344) [Auto] Updated Upstream (Bukkit/CraftBukkit) Cleanup javadoc warnings for 1.13 Cleanup javadoc warnings [Auto] Updated Upstream (Bukkit) Fix bug in last patch Ensure chunks are always loaded on hard position sets Improve Watchdog Early Warning Feature - Closes #1319 [Auto] Updated Upstream (CraftBukkit) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.