Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Patches #7541

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Remove Patches #7541

merged 1 commit into from
Mar 11, 2022

Conversation

Owen1212055
Copy link
Member

@Owen1212055 Owen1212055 commented Mar 4, 2022

Removes 5 patches:

  • Remove invalid mob spawner tile entities
  • Option to remove corrupt tile entities

If the block at the location doesn't support a tile entity, MC will not put it in the world. This meant that the "Option to remove corrupt tile entities" patch has not worked in a while either, as it doesn't exist in the world any more anyways.

  • Remove FishingHook reference on Craft Entity removal
  • Don't let fishing hooks use portals

Fishing hooks remove their "fisher" when they are removed.
Also, there is a getter preventing fish hooks from being able to move dimensions via portals.

  • Prevent Frosted Ice from loading/holding chunks

Tested this by checking if chunks were randomly ticked if chunk.areNeighboursLoaded(1) was false. This never occurred, confirming that these chunks are not ticked if there are no neighbors loaded. This patch I am a little uncertain on, so please comment if anything seems weird and I can revert this one.

  • Workaround for setting passengers on players

Seemed old, removing this causes no issues.

@EventHandler
    public void onInteract(PlayerInteractEntityEvent event) {
        event.getPlayer().addPassenger(event.getRightClicked());
    }

If I am missing anything with these patches, let me know, however, I'm fairly confident these should be able to be removed.

@Owen1212055 Owen1212055 requested a review from a team as a code owner March 4, 2022 22:06
Copy link
Member

@kennytv kennytv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the frosted ice patch

@Owen1212055 Owen1212055 force-pushed the remove-patches branch 2 times, most recently from 3d0f902 to b71066a Compare March 11, 2022 18:09
@kennytv kennytv merged commit ea1efef into PaperMC:master Mar 11, 2022
@Owen1212055 Owen1212055 deleted the remove-patches branch March 11, 2022 20:19
Owen1212055 added a commit to Owen1212055/docs that referenced this pull request Mar 12, 2022
AsP3X added a commit to AsP3X/papermc that referenced this pull request Mar 15, 2022
TASK: updated to latest build [#250] #13
Version update to the latest PaperMC build:

- [#250] [[a5be178](PaperMC/Paper@a5be178)] Use correct toX/Y/Z in player move packet handling
- [#249] [[c8e49cc](PaperMC/Paper@c8e49cc)] Add get/set wait time for fish hooks. ([#5595](PaperMC/Paper#5595))
- [#248] 
  | - [[1ce3555](PaperMC/Paper@1ce3555)] [ci-skip] Fix typo in feature request issue template ([#7593](PaperMC/Paper#7593))
  | - [[b65b48f](PaperMC/Paper@b65b48f)] [ci skip] Update gradle wrapper
- [#247] [[1358d1e](PaperMC/Paper@1358d1e)] Updated Upstream (CraftBukkit/Spigot) ([#7580](PaperMC/Paper#7580))
- [#246] [[ab03538](PaperMC/Paper@ab03538)] Fix colors in some console messages
- [#245] [[87927e1](PaperMC/Paper@87927e1)] Fix CreativeCategory API ([#7586](PaperMC/Paper#7586))
- [#244] [[bfa33d9](PaperMC/Paper@bfa33d9)] Various improvements to console color formatting ([#7560](PaperMC/Paper#7560))
- [#243] [[dc96bba](PaperMC/Paper@dc96bba)] Ensure the item sent isn't air ([#7584](PaperMC/Paper#7584))
- [#242] [[aab1f8a](PaperMC/Paper@aab1f8a)] Fix swamp hut cat generation deadlock
- [#241] [[ea1efef](PaperMC/Paper@ea1efef)] Remove Patches ([#7541](PaperMC/Paper#7541))
- [#240] [[1790528](PaperMC/Paper@1790528)] More projectile API ([#5731](PaperMC/Paper#5731))
- [#239] [[d714682](PaperMC/Paper@d714682)] Add more entity api ([#7564](PaperMC/Paper#7564))
- [#238] [[657d163](PaperMC/Paper@657d163)] Prevent despawned navigators being readded ([#7574](PaperMC/Paper#7574))
- [#237]
  | - [[b55ba19](PaperMC/Paper@b55ba19)] Update README for new docs ([#7561](PaperMC/Paper#7561))
  | - [[4423e12](PaperMC/Paper@4423e12)] Update docs link in paper.yml ([#7562](PaperMC/Paper#7562))
  | - [[7a21333](PaperMC/Paper@7a21333)] Fix setting the view distance to 32 ([#7503](PaperMC/Paper#7503))
- [#236] [[718fab1](PaperMC/Paper@718fab1)] Add CPU name and JVM vendor info in timings ([#7490](PaperMC/Paper#7490))
- [#235] [[e0b3f3f](PaperMC/Paper@e0b3f3f)] Adventure 4.10.1
- [#234] [[c34fb09](PaperMC/Paper@c34fb09)] Add ghast api ([#7554](PaperMC/Paper#7554))
- [#233] [[d9bf5e7](PaperMC/Paper@d9bf5e7)] Add method to set noclip on arrows ([#7263](PaperMC/Paper#7263))
- [#232] [[7b9c30f](PaperMC/Paper@7b9c30f)] Fix scoreboard objective name length limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants