Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements to console color formatting #7560

Merged
merged 1 commit into from
Mar 12, 2022
Merged

Various improvements to console color formatting #7560

merged 1 commit into from
Mar 12, 2022

Conversation

jpenilla
Copy link
Member

@jpenilla jpenilla commented Mar 9, 2022

  • Use Adventure's [char]#rrggbb RGB format internally instead of the unusual x repeated characters format
  • Option (default true) to use actual color for NamedTextColors instead of closest ANSI code
  • Use a rarely used character (0x7f) instead of section symbol for internal format

@jpenilla jpenilla requested a review from a team as a code owner March 9, 2022 02:53
@jpenilla jpenilla merged commit bfa33d9 into master Mar 12, 2022
@jpenilla jpenilla deleted the console-improvements branch March 12, 2022 21:31
@JRoy
Copy link
Member

JRoy commented Mar 13, 2022

you're incredibly stupid

Owen1212055 pushed a commit to Owen1212055/Paper that referenced this pull request Mar 13, 2022
@jpenilla @Owen1212055
Various improvements to console color formatting (PaperMC#7560)
6cf7b21
@AsP3X AsP3X mentioned this pull request Mar 15, 2022
Merged
AsP3X added a commit to AsP3X/papermc that referenced this pull request Mar 15, 2022
@AsP3X
Merge pull request #13 from AsP3X/development
e637e67 
TASK: updated to latest build [#250] #13
Version update to the latest PaperMC build:

- [#250] [[a5be178](PaperMC/Paper@a5be178)] Use correct toX/Y/Z in player move packet handling
- [#249] [[c8e49cc](PaperMC/Paper@c8e49cc)] Add get/set wait time for fish hooks. ([#5595](PaperMC/Paper#5595))
- [#248] 
  | - [[1ce3555](PaperMC/Paper@1ce3555)] [ci-skip] Fix typo in feature request issue template ([#7593](PaperMC/Paper#7593))
  | - [[b65b48f](PaperMC/Paper@b65b48f)] [ci skip] Update gradle wrapper
- [#247] [[1358d1e](PaperMC/Paper@1358d1e)] Updated Upstream (CraftBukkit/Spigot) ([#7580](PaperMC/Paper#7580))
- [#246] [[ab03538](PaperMC/Paper@ab03538)] Fix colors in some console messages
- [#245] [[87927e1](PaperMC/Paper@87927e1)] Fix CreativeCategory API ([#7586](PaperMC/Paper#7586))
- [#244] [[bfa33d9](PaperMC/Paper@bfa33d9)] Various improvements to console color formatting ([#7560](PaperMC/Paper#7560))
- [#243] [[dc96bba](PaperMC/Paper@dc96bba)] Ensure the item sent isn't air ([#7584](PaperMC/Paper#7584))
- [#242] [[aab1f8a](PaperMC/Paper@aab1f8a)] Fix swamp hut cat generation deadlock
- [#241] [[ea1efef](PaperMC/Paper@ea1efef)] Remove Patches ([#7541](PaperMC/Paper#7541))
- [#240] [[1790528](PaperMC/Paper@1790528)] More projectile API ([#5731](PaperMC/Paper#5731))
- [#239] [[d714682](PaperMC/Paper@d714682)] Add more entity api ([#7564](PaperMC/Paper#7564))
- [#238] [[657d163](PaperMC/Paper@657d163)] Prevent despawned navigators being readded ([#7574](PaperMC/Paper#7574))
- [#237]
  | - [[b55ba19](PaperMC/Paper@b55ba19)] Update README for new docs ([#7561](PaperMC/Paper#7561))
  | - [[4423e12](PaperMC/Paper@4423e12)] Update docs link in paper.yml ([#7562](PaperMC/Paper#7562))
  | - [[7a21333](PaperMC/Paper@7a21333)] Fix setting the view distance to 32 ([#7503](PaperMC/Paper#7503))
- [#236] [[718fab1](PaperMC/Paper@718fab1)] Add CPU name and JVM vendor info in timings ([#7490](PaperMC/Paper#7490))
- [#235] [[e0b3f3f](PaperMC/Paper@e0b3f3f)] Adventure 4.10.1
- [#234] [[c34fb09](PaperMC/Paper@c34fb09)] Add ghast api ([#7554](PaperMC/Paper#7554))
- [#233] [[d9bf5e7](PaperMC/Paper@d9bf5e7)] Add method to set noclip on arrows ([#7263](PaperMC/Paper#7263))
- [#232] [[7b9c30f](PaperMC/Paper@7b9c30f)] Fix scoreboard objective name length limit
This was referenced Apr 11, 2022
Closed
Closed
@addstar addstar mentioned this pull request Apr 25, 2022
Closed
@kangarko
Copy link

This shit just broke tons of plugins using § color formatting, and should be reversed as soon as possible

@electronicboy
Copy link
Member

§ has been deprecated for years and there's little interest trying to shim back in support for this, long term goals is to support logging components which do allow us to deal with this stuff without funky magic hiding in the logger chain, you can also do the generally supported thing for loggers and just log ansi in supported environments

@Astralchroma

This comment was marked as off-topic.

Sign in to view
@iGabyTM

This comment was marked as off-topic.

Sign in to view
@PaperMC PaperMC locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytv kennytv kennytv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jpenilla @JRoy @kangarko @electronicboy @Astralchroma @iGabyTM @kennytv