Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get/set wait time for fish hooks. #5595

Merged
merged 2 commits into from
Mar 13, 2022
Merged

Add get/set wait time for fish hooks. #5595

merged 2 commits into from
Mar 13, 2022

Conversation

Owen1212055
Copy link
Member

No description provided.

@Owen1212055 Owen1212055 requested review from a team as code owners May 8, 2021 23:33
kennytv
kennytv requested changes May 9, 2021
View reviewed changes
Copy link
Member

@kennytv kennytv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The descriptions are incorrect. The value is decreased and represents how long it takes until the fish/whatever will bubble towards the hook

@Owen1212055
Copy link
Member Author

Updated to 1.17, use access transformer on field.

@Owen1212055
Copy link
Member Author

rebased

@Machine-Maker
Copy link
Member

I'm thinking this is also missing entity API which can be placed in your missing entity API patch right?

@Owen1212055
Copy link
Member Author

I'm thinking this is also missing entity API which can be placed in your missing entity API patch right?

Sure, in which case I will wait for the cat api to be merged for this then.

@Machine-Maker Machine-Maker added the status: blocked Issue or Request is waiting on some other issue or change. label Jul 29, 2021
@Owen1212055
Copy link
Member Author

I am thinking that this can be in a separate patch as my patch is mostly for entity animations/behavior that are not exposed.

@Machine-Maker Machine-Maker added status: rebase required and removed status: blocked Issue or Request is waiting on some other issue or change. labels Oct 20, 2021
Machine-Maker
Machine-Maker approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@Machine-Maker Machine-Maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a quick rebase, but looks fine

@Owen1212055
Copy link
Member Author

Consider it done!

@Owen1212055
Copy link
Member Author

Rebased

@Owen1212055
Copy link
Member Author

Updated

@Owen1212055
Copy link
Member Author

Rebased (also remove this tag too please <3)

@Owen1212055
Copy link
Member Author

Rebased + merged into Projectile API patch

@Owen1212055
Copy link
Member Author

Having some issues here whoopsies.

@Owen1212055 Owen1212055 reopened this Mar 13, 2022
@Owen1212055
Copy link
Member Author

Should be ready, and rebased.

@electronicboy electronicboy merged commit c8e49cc into PaperMC:master Mar 13, 2022
@Owen1212055 Owen1212055 deleted the fish-hook-api branch March 13, 2022 22:36
@AsP3X AsP3X mentioned this pull request Mar 15, 2022
Merged
AsP3X added a commit to AsP3X/papermc that referenced this pull request Mar 15, 2022
@AsP3X
Merge pull request #13 from AsP3X/development
e637e67 
TASK: updated to latest build [#250] #13
Version update to the latest PaperMC build:

- [#250] [[a5be178](PaperMC/Paper@a5be178)] Use correct toX/Y/Z in player move packet handling
- [#249] [[c8e49cc](PaperMC/Paper@c8e49cc)] Add get/set wait time for fish hooks. ([#5595](PaperMC/Paper#5595))
- [#248] 
  | - [[1ce3555](PaperMC/Paper@1ce3555)] [ci-skip] Fix typo in feature request issue template ([#7593](PaperMC/Paper#7593))
  | - [[b65b48f](PaperMC/Paper@b65b48f)] [ci skip] Update gradle wrapper
- [#247] [[1358d1e](PaperMC/Paper@1358d1e)] Updated Upstream (CraftBukkit/Spigot) ([#7580](PaperMC/Paper#7580))
- [#246] [[ab03538](PaperMC/Paper@ab03538)] Fix colors in some console messages
- [#245] [[87927e1](PaperMC/Paper@87927e1)] Fix CreativeCategory API ([#7586](PaperMC/Paper#7586))
- [#244] [[bfa33d9](PaperMC/Paper@bfa33d9)] Various improvements to console color formatting ([#7560](PaperMC/Paper#7560))
- [#243] [[dc96bba](PaperMC/Paper@dc96bba)] Ensure the item sent isn't air ([#7584](PaperMC/Paper#7584))
- [#242] [[aab1f8a](PaperMC/Paper@aab1f8a)] Fix swamp hut cat generation deadlock
- [#241] [[ea1efef](PaperMC/Paper@ea1efef)] Remove Patches ([#7541](PaperMC/Paper#7541))
- [#240] [[1790528](PaperMC/Paper@1790528)] More projectile API ([#5731](PaperMC/Paper#5731))
- [#239] [[d714682](PaperMC/Paper@d714682)] Add more entity api ([#7564](PaperMC/Paper#7564))
- [#238] [[657d163](PaperMC/Paper@657d163)] Prevent despawned navigators being readded ([#7574](PaperMC/Paper#7574))
- [#237]
  | - [[b55ba19](PaperMC/Paper@b55ba19)] Update README for new docs ([#7561](PaperMC/Paper#7561))
  | - [[4423e12](PaperMC/Paper@4423e12)] Update docs link in paper.yml ([#7562](PaperMC/Paper#7562))
  | - [[7a21333](PaperMC/Paper@7a21333)] Fix setting the view distance to 32 ([#7503](PaperMC/Paper#7503))
- [#236] [[718fab1](PaperMC/Paper@718fab1)] Add CPU name and JVM vendor info in timings ([#7490](PaperMC/Paper#7490))
- [#235] [[e0b3f3f](PaperMC/Paper@e0b3f3f)] Adventure 4.10.1
- [#234] [[c34fb09](PaperMC/Paper@c34fb09)] Add ghast api ([#7554](PaperMC/Paper#7554))
- [#233] [[d9bf5e7](PaperMC/Paper@d9bf5e7)] Add method to set noclip on arrows ([#7263](PaperMC/Paper#7263))
- [#232] [[7b9c30f](PaperMC/Paper@7b9c30f)] Fix scoreboard objective name length limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electronicboy electronicboy electronicboy approved these changes

@qixils qixils qixils approved these changes

@Machine-Maker Machine-Maker Machine-Maker approved these changes

@Proximyst Proximyst Proximyst approved these changes

@kennytv kennytv kennytv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Owen1212055 @Machine-Maker @electronicboy @qixils @Proximyst @kennytv