Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix secure profile with proxy online mode #9700

Merged
merged 4 commits into from
Nov 4, 2023
Merged

fix secure profile with proxy online mode #9700

merged 4 commits into from
Nov 4, 2023

Conversation

NonSwag
Copy link
Sponsor Contributor

@NonSwag NonSwag commented Sep 10, 2023 •
edited by github-actions bot
Loading

Fixup of #9183 and #9256

Download the paperclip jar for this pull request: paper-9700.zip

@NonSwag NonSwag requested a review from a team as a code owner September 10, 2023 09:23
@Warriorrrr
Copy link
Member

Don't link to jars pls, we have a label for that

@Warriorrrr Warriorrrr added the build-pr-jar Enables a workflow to build Paperclip jars on the pull request. label Sep 10, 2023
@kennytv
Copy link
Member

kennytv commented Sep 10, 2023

The enforceSecureProxyProfile setting seems unnecessary when you can just toggle the setting in server properties?

@NonSwag
Copy link
Sponsor Contributor Author

NonSwag commented Sep 10, 2023 •
edited
Loading

The enforceSecureProxyProfile setting seems unnecessary when you can just toggle the setting in server properties?

removed

@MachineBreaker
Copy link

You might want to merge the patches tho

@NonSwag
Copy link
Sponsor Contributor Author

NonSwag commented Sep 23, 2023

bump

@LuggaPugga
Copy link

I really need this, this bug is so annoying

@NonSwag
Copy link
Sponsor Contributor Author

NonSwag commented Oct 8, 2023

I don't know whether the isProxyOnlineMode method provided the isOnlineMode check before, but I removed the unnecessary double check on my end.

@NonSwag
Copy link
Sponsor Contributor Author

NonSwag commented Oct 14, 2023 •
edited
Loading

bump nr2

@olijeffers0n
Copy link
Member

The Paper team is made of volunteers who all have lives. We appreciate that you would like this to be merged and we thank you for your work, however bumping like this is only irritating. Please refrain from doing this in future 😁

@NonSwag NonSwag requested a review from Leguan16 October 14, 2023 12:32
@electronicboy
Copy link
Member

I was worried about this PR given that it had some side effects internally which where overlooked and I didn't have the means to test/look into it, finally having good hardware, finally got to testing it, and it looks fine

@NonSwag
Copy link
Sponsor Contributor Author

NonSwag commented Oct 29, 2023

Is this going to be merged anytime soon?

@lynxplay lynxplay merged commit 2553f30 into PaperMC:master Nov 4, 2023
1 check passed
@lynxplay
Copy link
Contributor

lynxplay commented Nov 4, 2023

Yes!

@NonSwag NonSwag deleted the secure-profile-fix branch November 5, 2023 10:06
lynxplay pushed a commit to lynxplay/paper that referenced this pull request Feb 23, 2024
@NonSwag @lynxplay
fix secure profile with proxy online mode (PaperMC#9700)
e9046db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electronicboy electronicboy electronicboy approved these changes

@kennytv kennytv kennytv approved these changes

@lynxplay lynxplay lynxplay approved these changes

@Leguan16 Leguan16 Awaiting requested review from Leguan16

Assignees
No one assigned
Labels
build-pr-jar Enables a workflow to build Paperclip jars on the pull request.
Projects
Paper PR Queue
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@NonSwag @Warriorrrr @kennytv @MachineBreaker @LuggaPugga @olijeffers0n @electronicboy @lynxplay @Leguan16