-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix secure profile with proxy online mode #9700
Conversation
Don't link to jars pls, we have a label for that |
The enforceSecureProxyProfile setting seems unnecessary when you can just toggle the setting in server properties? |
removed |
You might want to merge the patches tho |
bump |
I really need this, this bug is so annoying |
I don't know whether the isProxyOnlineMode method provided the isOnlineMode check before, but I removed the unnecessary double check on my end. |
bump nr2 |
The Paper team is made of volunteers who all have lives. We appreciate that you would like this to be merged and we thank you for your work, however bumping like this is only irritating. Please refrain from doing this in future 😁 |
patches/server/1036-fix-secure-profile-with-proxy-online-mode.patch
Outdated
Show resolved
Hide resolved
I was worried about this PR given that it had some side effects internally which where overlooked and I didn't have the means to test/look into it, finally having good hardware, finally got to testing it, and it looks fine |
Is this going to be merged anytime soon? |
…patch Co-authored-by: leguan <59799222+Leguan16@users.noreply.github.com>
Yes! |
Fixup of #9183 and #9256
Download the paperclip jar for this pull request: paper-9700.zip