fix secure profile with proxy online mode

[NonSwag]

This change fixes the problem with the new unverified chat toast if the server is in offline-mode behind an online-mode proxy.

[NonSwag]

Someone wants to review this ?

[lynxplay]

This, unless I am missing something, can just use io.papermc.paper.configuration.GlobalConfiguration.Proxies#isProxyOnlineMode to avoid this code duplication.

[NonSwag]

Thanks for the tip, done!

[Warriorrrr]

Shouldn't this be enforceSecureProfile && (onlineMode || proxyOnlineMode), right now if the enforce-secure-profile option is disabled in the properties but proxy online mode is used it'll be enforced, or is this intended?

[NonSwag]

missed that sorry

[MiniDigger]

please merge your patches by amending your original commit instead of creating a new one

[NonSwag]

I don't know how to merge commits after they are already pushed
I've deleted the first file, so the merge would only consist out of 17e7bb7

[NonSwag]

Anything else that I can improve, or does someone want to accept/close the PR?

[electronicboy]

Has this been properly tested on velocity and bungee/waterfall, especially around stuff like server switches? I'd imagine velocity is fine, not sure about the latter, however

[NonSwag]

Yes, I've tested all of them.
Velocity is working as it should (it just forwards the value the requested server provides).
BungeeCord works even without that (I guess they just say true all the time).
Waterfall does (seemingly) not change the behavior of BungeeCord.
I can't see any (negative) effects from that code change on BungeeCord or Waterfall.

[electronicboy]

It's not just a value which is passed to the client which is my concern, there's some internal logic which is backed off that

…

On Thu, 11 May 2023, 14:26 NonSwag, ***@***.***> wrote: Yes, I've tested all of them. Velocity is working as it should (it just forwards the value the requested server provides). BungeeCord works even without that (I guess they just say true all the time). Waterfall does (seemingly) not change the behavior of BungeeCord. I can't see any (negative) effects from that code change on BungeeCord or Waterfall. — Reply to this email directly, view it on GitHub <#9183 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAZHC5LKLZDAOVLCUQ2TXFTSI7ANCNFSM6AAAAAAXWDHWQY> . You are receiving this because your review was requested.Message ID: ***@***.***>

[NonSwag]

I've checked everything related to that option.
It changes just the ServerData which is only sent to the user and the chat signing.

[NonSwag]

Anything else that I can improve, or does someone want to accept/close the PR?

what about now ?

[NonSwag]

Hello?

[Warriorrrr]

The patch as it is now won't apply since you deleted the first patch that it depended on, you need to undo the deletion of the first patch and then amend the second one into it like mini said.