-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acknowledge seen messages to server when running proxy commands #1100
Conversation
So, I have command handling working on the proxy for 1.20.2, cancelling chat doesn't work, but, I think the issue is obvious, I need to store the old offset and use that rather than grabbing the one in the packet |
So, it seems that we can only use this for preventing cases where we're not actually seeing signed stuff, I am probably going to merge this (soon) as is in order to fix command handling on the proxy, might be nice for somebody else to test this, need to add support for some older versions, forgot what ver mojang added the packet we're using here in |
.../main/java/com/velocitypowered/proxy/protocol/packet/chat/session/SessionCommandHandler.java
Outdated
Show resolved
Hide resolved
.../main/java/com/velocitypowered/proxy/protocol/packet/chat/session/SessionCommandHandler.java
Outdated
Show resolved
Hide resolved
* Add version information for 1.20.1 (PaperMC#1021) * bump adventure to 4.14.0 (PaperMC#1034) * check if a plugin has a executor service (PaperMC#1038) * check if a plugin has an executor service * checkstyle * feat: add TabList#addEntries (PaperMC#987) * [ci skip] Replaced weired i with i in javadocs (PaperMC#1057) In this little patch I replaced an i which caused my build process to crash with an i * Do not track plugin channels registered per-player on the proxy (PaperMC#591) We don't need to track this information since Velocity uses the JoinGame packet, which is about as good of a server rejoin mechanism we're likely to get in vanilla Minecraft. * fix PaperMC#1062 * 1.20.2 Support (PaperMC#1088) Co-authored-by: RednedEpic <redned235@gmail.com> Co-authored-by: Gero <gecam59@gmail.com> * Actually send plugin message registration to backend servers I don't see where this was ever done, and don't see how plugin messaging could of ever worked, at least within the confines of CB and co, given the fact that we never seemed to be sending this to the backend? * appease checkstyle, move back to older fix placement * Change packet decode logging prompt * Catch throwables when loading plugins (PaperMC#1098) * Several improvements and fixes for 1.20.2 (PaperMC#1097) * Send LoginAcknowledged immediately * Resend player list header/footer after backend server switched to config state * Fix clearHeaderAndFooter not clearing fields in ConnectedPlayer * Clear boss bars, header/footer, tab list when switching client to config state * Send client settings in config state * Fix unsigned commands detected as signed (PaperMC#1082) * fix: commands flagged as signed without signed arguments * feat: improve error message for illegal protocol state. * acknowledge seen messages to server when running proxy commands (PaperMC#1100) * Implement ComponentLogger (PaperMC#1022) * Log the protocol phase in case of trying to obtain a packet id not existing in the phase (PaperMC#1107) * Bump netty to 4.1.100.Final (PaperMC#1067) --------- Co-authored-by: Pantera (Mad_Daniel) <89838384+Pantera07@users.noreply.github.com> Co-authored-by: chris <reichel32574@gmail.com> Co-authored-by: Aaron <71191102+RealBauHD@users.noreply.github.com> Co-authored-by: powercas_gamer <cas@deltapvp.net> Co-authored-by: Groldi <53694440+Plugrol@users.noreply.github.com> Co-authored-by: Andrew Steinborn <git@steinborn.me> Co-authored-by: Emmanuel Lampe <rexlmanude@gmail.com> Co-authored-by: Paul <Paul19988@users.noreply.github.com> Co-authored-by: RednedEpic <redned235@gmail.com> Co-authored-by: Gero <gecam59@gmail.com> Co-authored-by: Shane Freeder <theboyetronic@gmail.com> Co-authored-by: Joo200 <github@joo200.de> Co-authored-by: Adrian <68704415+4drian3d@users.noreply.github.com>
* 1.20.2 Support (PaperMC#1088) Co-authored-by: RednedEpic <redned235@gmail.com> Co-authored-by: Gero <gecam59@gmail.com> * Actually send plugin message registration to backend servers I don't see where this was ever done, and don't see how plugin messaging could of ever worked, at least within the confines of CB and co, given the fact that we never seemed to be sending this to the backend? * appease checkstyle, move back to older fix placement * Change packet decode logging prompt * Catch throwables when loading plugins (PaperMC#1098) * Several improvements and fixes for 1.20.2 (PaperMC#1097) * Send LoginAcknowledged immediately * Resend player list header/footer after backend server switched to config state * Fix clearHeaderAndFooter not clearing fields in ConnectedPlayer * Clear boss bars, header/footer, tab list when switching client to config state * Send client settings in config state * Fix unsigned commands detected as signed (PaperMC#1082) * fix: commands flagged as signed without signed arguments * feat: improve error message for illegal protocol state. * acknowledge seen messages to server when running proxy commands (PaperMC#1100) * Implement ComponentLogger (PaperMC#1022) * Log the protocol phase in case of trying to obtain a packet id not existing in the phase (PaperMC#1107) * Bump netty to 4.1.100.Final (PaperMC#1067) --------- Co-authored-by: Paul <Paul19988@users.noreply.github.com> Co-authored-by: RednedEpic <redned235@gmail.com> Co-authored-by: Gero <gecam59@gmail.com> Co-authored-by: Shane Freeder <theboyetronic@gmail.com> Co-authored-by: Joo200 <github@joo200.de> Co-authored-by: Adrian <68704415+4drian3d@users.noreply.github.com> Co-authored-by: Pantera (Mad_Daniel) <89838384+Pantera07@users.noreply.github.com>
This fixes aspects like running /server from causing clients to disconnect the next time they interface with the server, as well as restores the ability to cancel signed chat messages on current versions. This will apply to at least 1.20, but, need to adjust the protocol checks and do some further checking