[Icon request] KDE Partition Manager

[ocobblepot]

KDE has updated the icon for its Partition Manager.

The icon name in Papirus (and Breeze) is partitionmanager.svg

The new icon is here https://github.com/KDE/breeze-icons/blob/master/icons/apps/48/partitionmanager.svg

[morganist]

@ocobblepot
But partitionmanager.svg is a standard icon for all partition managers in Papirus. Do we really need a special icon for a partition manager that is made by KDE?

[ocobblepot]

But partitionmanager.svg is a standard icon for all partition managers in Papirus.

I couldn't find any other app icons with "part" in the name that link to it.

Do we really need a special icon for a partition manager that is made by KDE?

GParted has it's own icon (gparted.svg). Also the current Papirus icon for partitionmanager.svg resembles the Breeze icon for Filelight https://github.com/KDE/breeze-icons/blob/master/icons/apps/48/filelight.svg rather than the new one for Partition manager above.

[morganist]

so, we could symlink filelight papirus icon to partitionmanager.svg because of the resamblance. But:
@SmartFinn categorised disk icons here back in 2017: 5fa399a
Since then, many disk apps gained their own icon (for example, baobab)
Maybe we need to rename partitionmanager.svg to disk-usage-analyzer.svg? And vise versa? Or maybe we also need to set the gparted icon as a standard partition manager icon and use it for this one too...

[morganist]

Actually, now i agree that KDE partition manager needs its own icon – there isn't a lot of GUI partition managers availible on linux, it seems. But the filelight icon issue still persists. Also, is there any app symlinks in Papirus that use partitionmanager.svg? If not, would it really be better to use its icon for filefight and other disk usage analyzers, and make a new one for it, for KDE partition manager? After all, KDE literally named it partitionmanager...

[morganist]

Papirus partition manager icon and Filelight icon:

The partition manager icon really should be dedicated to KDE partition manager, while the current icon is a better fit for disk image analyzers.

[morganist]

@SmartFinn do we need a separate issue for that?

[SmartFinn]

@morganist that's make sense. I'll review the changes made in this commit 5fa399a

[morganist]

how about this design?

[SmartFinn]

@morganist

how about this design?

This is a good one. I like it. This is may be just a circle for 16/22/24px icons, and a drive with the circle for 32/48/64px.

[morganist]

cool, i agree!
i'll try.
but we still need to solve the problem on how to handle disk-usage-analyzer and partitionmanager.
i think papirus doesn't need a general icon for partition managers, there's, like, only 4 of them (gparted, gnome disks, kde partition manager, yast-disk).
we just give them all a unique icon.
i'll do kde partition manager today, and something needs to be done with yast-disk (openSUSE's YaST Expert Partitioner)

[morganist]

i think it'll be fine if yast-disk.svg stays symlinked to disk-utility.svg

[SmartFinn]

@morganist

but we still need to solve the problem on how to handle disk-usage-analyzer and partitionmanager.

Just wait with the PR, I'll replace it today.

[SmartFinn]

@morganist let's reschedule this changes to the next release. 6666 commits is a nice number to tag the release. I'll do the changes tomorrow, or today to a separated branch.

[morganist]

let's reschedule this changes to the next release.

and when would you do a full release?

[SmartFinn]

@morganist

and when would you do a full release?

It's today.

[SmartFinn]

@morganist

I decided, don't replace disk-usage-analyzer with partitionmanager icon because it's only filelight and mate-disk-usage-analyzer have the rings chart view from the whole list:

disk-usage-analyzer.svg
|- diskmonitor.svg
|- gdmap_icon.svg
|- gsmartcontrol.svg
|- kdf.svg
|- kdiskfree.svg
|- kwikdisk.svg
|- mate-disk-usage-analyzer.svg
|- org.kde.plasma.systemmonitor.diskactivity.svg
|- org.kde.plasma.systemmonitor.diskusage.svg
|- preferences-smart-status.svg
|- xfce-mount.svg

Now, the old partitionmanager icon is filelight icon. partitionmanager is a temporary symlink to gparted icon and wait for your PR.

[morganist]

cool! well then i agree that it's okay for the others to just stay symlinked to `disk-usage-analyzer`. now i just need to apply the pixel-perfect fix for 32x32 `org.gnome.DuskUtility` and submit them together just as i did with gnome-firmware.

…

On 2 August 2023 14:28:08 GMT+07:00, Sergei Eremenko ***@***.***> wrote: @morganist I decided, don't replace `disk-usage-analyzer` with `partitionmanager` icon because it's only `filelight` and `mate-disk-usage-analyzer` have the rings chart view from the whole list: ``` disk-usage-analyzer.svg |- diskmonitor.svg |- gdmap_icon.svg |- gsmartcontrol.svg |- kdf.svg |- kdiskfree.svg |- kwikdisk.svg |- mate-disk-usage-analyzer.svg |- org.kde.plasma.systemmonitor.diskactivity.svg |- org.kde.plasma.systemmonitor.diskusage.svg |- preferences-smart-status.svg |- xfce-mount.svg ``` Now, the old `partitionmanager` icon is `filelight` icon. `partitionmanager` is a temporary symlink to `gparted` icon and wait for your PR. -- Reply to this email directly or view it on GitHub: #3451 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

[ocobblepot]

Thank you both.