Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for KDE Partition Manager and GNOME Disks fixes #3505

Merged
merged 5 commits into from
Aug 2, 2023
Merged

Add icon for KDE Partition Manager and GNOME Disks fixes #3505

merged 5 commits into from
Aug 2, 2023

Conversation

morganist
Copy link
Contributor

closes #3451
Tweaked the shadows for org.gnome.DiskUtility;
Remade the 32x32 org.gnome.DiskUtility.svg to make it pixel-perfect;
Remade the 16x16 org.gnome.DiskUtility.svg to make it pixel-perfect, less busy, simpler, and more readable;
Added an icon for KDE Partition Manager to the file partitionmanager.svg;
Added a symlink org.kde.partitionmanager.svg and symlinked it to org.kde.partitionmanager;

image
Previous GNOME Disks 16x16 icon and a new one side by side

image
New icon for KDE Partition manager and an original one

@SmartFinn
Copy link
Member

@morganist Thanks for the icons.

Could you try to improve the pixel alignment in 48px and 64px icon?

image

@SmartFinn
Copy link
Member

@morganist I forget to say that 22px and 24px are already fixed locally.

@morganist
Copy link
Contributor Author

@morganist I forget to say that 22px and 24px are already fixed locally.

Oh, okay. So you'll push these fixes after merging this pull request?

@SmartFinn
Copy link
Member

@morganist no, commit the fixes here now

@morganist
Copy link
Contributor Author

I made 48x48 and 64x64 icons pixel-perfect (for both partitionmanager and org.gnome.DiskUtility)
And you do already have a fix for 22x22 and 24x24 icons locally, right?

@SmartFinn
Copy link
Member

@morganist

I made 48x48 and 64x64 icons pixel-perfect (for both partitionmanager and org.gnome.DiskUtility)

Nice work. Thank you!

And you do already have a fix for 22x22 and 24x24 icons locally, right?

This is correct.

- Fix render issue with the ring
- Remove outline from disk icons
@SmartFinn SmartFinn merged commit f3ddb0a into PapirusDevelopmentTeam:master Aug 2, 2023
1 check passed
@morganist morganist deleted the partitionmanager branch August 2, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon request] KDE Partition Manager
2 participants