-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Designed disabling retrospective anonymity #5419
Comments
I think related is the ability to have "non-hidden" tickets in the reflections. I think anonymity can be toggled as well. |
Bumping this one up the backlog a bit based on the frequency of feedback we keep getting |
This customer 🔒 emailed me today:
|
New designs ready! https://www.figma.com/file/o3q946BB5UlYZw0RJeNHdx/Non-anonymous-retros?node-id=0%3A1 Meeting setup logic:
Reflection card logic:
|
@acressall as we discussed, I think this design is a good starting point. Couple of thoughts:
|
As written, this is pretty difficult! Our new WYSIWYG editor, TipTap, is almost at feature parity with DraftJS, which is what reflections use today. If we build to spec, I'd suggest we wait until we move reflections to the TipTap editor so we don't throw any work away. I imagine this'll be done in the next month or 2. Alternatively, we do what we do in the discuss phase today when you reply to a reply. It acts like instagram & just at-mentions the person you're replying to. you hit backspace & that mention goes away. we could borrow that pattern & build this quickly. The downside is folks could remove their name if they wanted to. Overall, the feel of it is a little janky, I don't love injecting text on a user's behalf & the value add is just typing someones name for them, which doesn't feel overly compelling. Another alternative would be to stick their avatar on the card as a watermark like we do with integrated tasks. that way it's immediately obvious that it's not anonymous & there's no way they could remove it. we could build that quickly. |
Thanks for your feedback @mattkrick! I want to make sure I understand correctly..
It sounds like this is the simplest solution, is that correct? Would it be just as easy to have the user's name rather than their avatar? In a design chat we thought the name at the end of the card (below the reflection, rather than appended) would be ideal but assumed it would be more work than appending. If that was a wrong assumption, I'm all for changing it! |
The idea of an avatar watermarks concerns me. I have this impression folks don’t upload their avatars, but I wonder if we could find out. If I just saw some random ‘J’ or a ‘T’ on one of our cards I may wonder who that is. Sure, in this case folks would benefit from uploading their avatar as in other places (avatar groups for presence, or voting, etc.). I think this will still be frustrating for people. I agree if I saw a photo it may be quicker recognition except for those folks that use avatars that aren’t clear and I forget who they are. On the other hand, I think using text actually gives more priority to the written content without decorating with a face. I think in general these should feel generative and less anchored on the person. A name I have to read feels less personal than a face, which is the information hierarchy that makes sense to me. It also probably keeps the cards feeling lighter. It’s a trade-off: a face per card (feels a little heavier to me) or an inline name per card that sometimes causes wrapping, sometimes doesn’t. For the times it doesn’t cause wrapping we’re effectively maintaining the same, lighter footprint we have today. |
Raising a +1 to Terry's concerns above. A watermarked avatar would not be clear enough and will instead make it harder or cumbersome to identify the author. On short reflections (a few words, one line) the watermark will most likely be behind the text making it hard to read. To me, appending the name after the text feels like the safest idea to try. |
@mattkrick is a version of this where the name is below the reflection (and essentially separate) any simpler than the design concept above? My aim is:
|
I assume both will take some work: A) switch to the new editor; add a name inline B) add the name below the content; this adds a condition to laying out the cards in any view or state (e.g. the animation while being dragged by another user), which to my understanding is not trivial In either case, I think appending a name is the better design path, and am willing to see the work done for it. However, since it’s less than trivial, it may delay shipping what seems like a simple addition as it competes for dev time. I can be okay with that, too. I’m not confident that using avatars for this purpose is a strong enough UX to justify making it because of the trade-off for a simple dev solution. |
I'd like to make sure we don't over-discuss and can propose a path forward. As I understand it, this change could have an impact on one of our largest accounts. I personally prefer the second design, but will concede this is a personal preference. I think both options are safe from a UX perspective, so would like a developer to make the call on which is the simplest to implement. |
@acressall Once this issue has passed design review, please create an implementation issue in "Backlog" for it. |
Adding the name at the bottom of the card feels safe and is not technically difficult. I wonder if we should add the avatar there as well like in the task cards, or if this would be too distracting and could lead to ambiguities? |
I'd like to leave out the avatar for now for two reasons:
|
I created the implementation issue: #7032 |
In addition to changing the placeholder + adding the user's name, have we considered something like a modal when a user enters a meeting explaining that reflections are non-anonymous, either as part of this issue or in a follow-up? I'd worry that putting the user's name on the card and changing the placeholder may still be too subtle for some users. E.g. a pop-up on meeting launch that says something like
with a little "got it" primary button that closes the modal |
@jmtaber129 I like the empathy toward potentially catching folks off guard. I wonder what user job stories may be at play.
|
Napkin sketch for indicating non-anonymous mode, do not ship! 🤣 |
This user 🔒 also asked if reflections could be non-anonymous. |
Issue - Enhancement
From #2806:
Before a retro meeting starts, the facilitator can toggle on/off the anonymity of reflections, and meeting participants are made aware of it.
Open questions
Acceptance criteria
Estimated effort
The text was updated successfully, but these errors were encountered: