Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow meeting to be reset to the reflect phase #7181

Closed
wants to merge 1 commit into from

Conversation

igorlesnenko
Copy link
Contributor

Description

Fixes #4881

Allows retro meeting to be reset to the reflect phase

Demo

Loom: https://www.loom.com/share/edf4861480be42d18c25a2d25411fb57

image

image

Testing scenarios

  • Create a meeting with at least 2 participants
  • Add reflections for both participants, go to group phase, create some groups
  • Go back to reflect phase, reset meeting
  • Check that meeting was correctly reset for the second participant in real time
  • Check that all meeting functionality works correctly for both participants and you can go through all phases and finish the meeting.
  • Try to reset meeting from discussion phase or vote phase too

@igorlesnenko igorlesnenko marked this pull request as ready for review September 14, 2022 16:35
@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
13.8% 13.8% Duplication

@mattkrick
Copy link
Member

My .02:

  • From a psychological standpoint, when a meeting goes backwards instead of forwards, it feels bad. Speaking for myself, whenever the person leading a meeting says "let's go back and redo..." I disengage. The root cause here is that the facilitator moved forward before the team was ready. Preventing them from making a mistake is always preferable to allowing them to undo the mistake!
  • Why does the facilitator move forward before everybody is ready? If everyone else hasn't clicked the "Ready" button, then when the facilitator clicks "next" they get a tooltip and have to click "next" again to move forward. This is the area that's broken! Is the tooltip unclear? How could we make the words more meaningful? Do we say "Is everyone ready? If so click next again". Should we specify that if they move forward they can't move back? Do they know that the team can still add reflections in the group phase?

@mattkrick mattkrick deleted the reset-retro branch December 1, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

people accidentally advancing through retro phases then can't go back
2 participants