Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tiptap): Upgrade tiptap to pull in bugfixes #7790

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

jmtaber129
Copy link
Contributor

Description

Fixes #7524

Now that ueberdosis/tiptap#3732 has been merged and a new tiptap release has been cut, upgrade @tiptap/extension-link@2.0.0-beta.218, which includes the fix for #7524.

Some parts of TipTap's core have changed across beta versions (e.g. the need to install @tiptap/pm), so I'm upgrading all TipTap packages to the most recent version (vs. just a select few) to ensure consistency.

Demo

N/A

Testing scenarios

Go through the repro steps in #7524 before and after this upgrade, and confirm upgrading fixes the issue.

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label One Review Required if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

"@tiptap/extension-mention": "^2.0.0-beta.218",
"@tiptap/extension-placeholder": "^2.0.0-beta.218",
"@tiptap/html": "^2.0.0-beta.218",
"@tiptap/pm": "^2.0.0-beta.218",
Copy link
Contributor Author

@jmtaber129 jmtaber129 Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is a new package we need to add now that we have packages newer than 2.0.0-beta.210. See https://tiptap.dev/installation/react#2-install-the-dependencies

Copy link
Contributor

@BartoszJarocki BartoszJarocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! also, I couldn't reproduce the bug you mentioned so should be all good

@jmtaber129 jmtaber129 merged commit af58a38 into master Feb 21, 2023
@jmtaber129 jmtaber129 deleted the jmtaber129/upgrade-tiptap-beta-218 branch February 21, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standups: multiple hyperlinks in the same update point to one URL
2 participants