chore: remove node-fetch from app code #8178
Conversation
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size. |
| @@ -38,7 +37,8 @@ const updateUserProfile = async ( | |||
|
|
|||
| if (validUpdatedUser.picture && validUpdatedUser.picture.endsWith('.svg')) { | |||
| const res = await fetch(validUpdatedUser.picture) | |||
| const buffer = await res.buffer() | |||
| const arrayBuffer = await res.arrayBuffer() | |||
There was a problem hiding this comment.
this is the only real change
There was a problem hiding this comment.
+1 That piece of code is unused. Apparently we only have one place where we call updateUserProfile and there we only update the name:
We seem to only upload images via
uploadUserImage where we convert SVGs to PNG firstThere was a problem hiding this comment.
right you are! we got some good spaghetti code going on there.
shall i remove that .svg conditional clause in this PR or should we save it for later? OK with either option.
There was a problem hiding this comment.
Let's leave it for later and then let's remove the picture input from this mutation completely.
| @@ -55,7 +55,7 @@ | |||
| "eslint-plugin-emotion": "^10.0.14", | |||
| "eslint-plugin-react": "^7.16.0", | |||
| "eslint-plugin-react-hooks": "^1.6.1", | |||
| "jest": "^27.0.6", | |||
| "jest": "^29.5.0", | |||
There was a problem hiding this comment.
native fetch isn't available to jest until v28 so i bumped to latest
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size. |
| @@ -38,7 +37,8 @@ const updateUserProfile = async ( | |||
|
|
|||
| if (validUpdatedUser.picture && validUpdatedUser.picture.endsWith('.svg')) { | |||
| const res = await fetch(validUpdatedUser.picture) | |||
| const buffer = await res.buffer() | |||
| const arrayBuffer = await res.arrayBuffer() | |||
There was a problem hiding this comment.
+1 That piece of code is unused. Apparently we only have one place where we call updateUserProfile and there we only update the name:
We seem to only upload images via
uploadUserImage where we convert SVGs to PNG firstSigned-off-by: Matt Krick <matt.krick@gmail.com>
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size. |
Description
.buffer, which doesn't exist on native fetchTesting scenarios