Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartbeat sound port from Baystation12/Baystation12#8386 #590

Merged
merged 6 commits into from Mar 19, 2015

Conversation

tigercat2000
Copy link
Contributor

This ports and adapts Baystation12/Baystation12#8386 to paracode.

Basics of what it does:

  • Adds a heartbeat sound to mobs that have hearts.
  • Sound only plays when one of the following is met:
    • Mob is in shock (shock_stage > 10)
    • Mob is in space (get_turf /turf/space)
    • Mob's pulse is over 120 (pulse >= PULSE_2FAST)
  • Does not play if mob has a robotic heart.

Edit:

  • New thing: SOUND_HEARTBEAT
    • Preference option that allows you to toggle heartbeat sounds on and off.
  • Another new thing: Different sounds for assisted and mechanical hearts.
    • Mechanical hearts (and machine people) get a dubstep-like sound.
    • Assisted hearts get the first part of the mechanical heart sound, followed by a normal heart beat.

EditEdit: Made a small demonstration video for listening to the sounds.
https://youtu.be/rCR60fjyyiQ

@mvanalphen mvanalphen added the Feature This PR is a new addition to the game label Mar 17, 2015
@Fox-McCloud
Copy link
Member

Big thumbs down to this one unless it's a player config option---sorry, but I don't want to be hearing my own heartbeat 24/7 just because I'm in space or happen to be using several drugs; miners and engineers already have enough going against them; having a repetitive heartbeat sound play 24/7 is just going to get distracting (nukies as well).

@tigercat2000
Copy link
Contributor Author

It plays once every 6-7 seconds in my experience, and it isn't very loud. It really isn't as distracting as it seems like it would be. It's more of a subtle-indicator type deal, that your pulse is either too fast, you are in shock, or you are in space. Another thing, I suppose I could try to tie it into the ambiance toggle, if it is really a problem

@Spacemanspark
Copy link
Contributor

I like it.

@Fox-McCloud
Copy link
Member

Let me clarify; I have no problem with this IF it's a config option (not tied to environmental though), otherwise 👎 from me.

@Fox-McCloud Fox-McCloud added the Sound This PR modifies the game sound label Mar 17, 2015
@tigercat2000
Copy link
Contributor Author

Can do, working on it now.

@Fox-McCloud
Copy link
Member

👍

@fj45
Copy link
Contributor

fj45 commented Mar 17, 2015

Not sure about it playing in space, wouldn't mind having sounds in space return completely. As "unrealistic" it is, it just doesn't work to have everything quiet.

@tigercat2000
Copy link
Contributor Author

@fj45 if that decision is made, I'm sure it wouldn't be too much of an issue to revert this PR.
As for now, however, space is pretty quiet with only the ambient space sounds, so this gives it a bit more of a creepy atmosphere walking around outside the station.

@Fox-McCloud
Copy link
Member

@fj45

With the way this is set up you can turn it off if you don't like it.

@fj45
Copy link
Contributor

fj45 commented Mar 18, 2015

Yes, just saying that I would much prefer sounds to still exist in space. Not really for this PR though.

ZomgPonies added a commit that referenced this pull request Mar 19, 2015
@ZomgPonies ZomgPonies merged commit ab619f6 into ParadiseSS13:master Mar 19, 2015
@tigercat2000 tigercat2000 deleted the HeartBeatPort branch March 20, 2015 10:20
mattgroy pushed a commit to mattgroy/Paradise that referenced this pull request Nov 10, 2023
<!-- Пишите **НИЖЕ** заголовков и **ВЫШЕ** комментариев, иначе что то
может пойти не так. -->
<!-- Вы можете прочитать Contributing.MD, если хотите узнать больше. -->

## Что этот PR делает
Убрал шкафы на замках из комнаты улик, добавил два зарядника в оружейку
<!-- Вкратце опишите изменения, которые вносите. -->
<!-- Опишите **все** изменения, так как противное может сказаться на
рассмотрении этого PR'а! -->
<!-- Если вы исправляете Issue, добавьте "Fixes ParadiseSS13#1234" (где 1234 - номер
Issue) где-нибудь в описании PR'а. Это автоматически закроет Issue после
принятия PR'а. -->

## Почему это хорошо для игры
Возможно.
<!-- Опишите, почему, по вашему, следует добавить эти изменения в игру.
-->

## Изображения изменений
<!-- Если вы не меняли карту или спрайты, можете опустить эту секцию.
Если хотите, можете вставить видео. -->

![image](https://github.com/ss220club/Paradise-SS220/assets/144079671/ea8c04af-9437-42f0-91f2-c7637093e04a)

![image](https://github.com/ss220club/Paradise-SS220/assets/144079671/52221736-f646-4193-9e17-5a4c6b505fb9)

## Тестирование
<!-- Как вы тестировали свой PR, если делали это вовсе? -->
ноуп
## Changelog

:cl:
add: Дельта: в оружейной добавлено два зарядника для оружия.
fix: Дельта: в комнате для улик в бриге теперь простые шкафы.
/:cl:

<!-- Оба :cl:'а должны быть на месте, что-бы чейнджлог работал! Вы
можете написать свой ник справа от первого :cl:, если хотите. Иначе
будет использован ваш ник на ГитХабе. -->
<!-- Вы можете использовать несколько записей с одинаковым префиксом
(Они используются только для иконки в игре) и удалить ненужные. Помните,
что чейнджлог должен быть понятен обычным игроком. -->
<!-- Если чейнджлог не влияет на игроков(например, это рефактор), вы
можете исключить всю секцию. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR is a new addition to the game Sound This PR modifies the game sound
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants