Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update line to 150 #3176

Closed
wants to merge 0 commits into from
Closed

update line to 150 #3176

wants to merge 0 commits into from

Conversation

marameref
Copy link
Contributor

Description

Please include a summary of the change and (optionally) which issue is fixed. Please also include
relevant motivation and context.

Reduced flake-8 maximum length (from 151 to 150 ) and changed some lines to conform to the new configuration

Changed Behaviour

Which existing user workflows or functionality will behave differently after this PR?

This PR wont change any behaviour of the project

Fixes

Fixes #3105

Type of change

Choose which options apply, and delete the ones which do not apply.

  • Code maintenance/cleanup

@marameref
Copy link
Contributor Author

@benclifford pls review my PR

Copy link
Collaborator

@benclifford benclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you committed a lot of changes to this branch that you maybe didn't intend to - scroll through the files changed branch and I think a lot of those changes you didn't really intend to be changed in the official Parsl release (for example, in some cases it looks like you might have accidentally reverted other peoples bug fixes)

@benclifford benclifford self-requested a review March 7, 2024 10:49
Copy link
Collaborator

@benclifford benclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you committed a lot of changes to this branch that you maybe didn't intend to - scroll through the files changed branch and I think a lot of those changes you didn't really intend to be changed in the official Parsl release (for example, in some cases it looks like you might have accidentally reverted other peoples bug fixes)

@marameref
Copy link
Contributor Author

i am working on it, will create a new PR in an hour if you dont mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outreachy: getting familiar with the development environment
2 participants