Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scroll feature to display all results #3

Open
ParthJadhav opened this issue Dec 27, 2022 · 8 comments · May be fixed by #35
Open

Add scroll feature to display all results #3

ParthJadhav opened this issue Dec 27, 2022 · 8 comments · May be fixed by #35
Assignees
@benediktms
Labels
enhancement New feature or request in-progress Some user has taken up this issue to work on.

Comments

@ParthJadhav
Copy link
Owner

This task involves adding a scroll feature to the application to allow users to view all of the search results, rather than just a limited number which is 5 currently.
@ParthJadhav ParthJadhav added enhancement New feature or request TODO labels Dec 27, 2022
@ParthJadhav ParthJadhav changed the title 📜 Add scroll feature to display all results Add scroll feature to display all results Dec 27, 2022
@ParthJadhav ParthJadhav removed the TODO label Jan 2, 2023
@benediktms
Copy link
Contributor

I'd like to start contributing towards this if possible

@ParthJadhav
Copy link
Owner Author

I'd like to start contributing towards this if possible

Sure @benediktms , You can take this up. I'll assign this to you. Do you have any questions to clear up?

@ParthJadhav ParthJadhav added the in-progress Some user has taken up this issue to work on. label Jan 9, 2023
@benediktms
Copy link
Contributor

@ParthJadhav not right now, but probably I will, I've not used Svelte before (but happy to learn).

@ParthJadhav
Copy link
Owner Author

I've

Okay, No Problem. Do you want me to remove the assignments? You could ping me whenever u are free to work 🙌

@benediktms
Copy link
Contributor

I'll try my hand at this over the course of the week, if I find that I'm too far out of my depth then I'll let you know!

@ParthJadhav
Copy link
Owner Author

I'll try my hand at this over the course of the week, if I find that I'm too far out of my depth then I'll let you know!

Okay, Thanks 🤝

@benediktms
Copy link
Contributor

benediktms commented Jan 12, 2023 •
edited
Loading

@ParthJadhav Do you mind if I add prettier to get consistent formatting?

@ParthJadhav
Copy link
Owner Author

ParthJadhav commented Jan 12, 2023 •
edited
Loading

Yeah, We need that actually 😅 Please feel free to create a PR.

@benediktms

This was referenced Jan 12, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benediktms benediktms

Labels
enhancement New feature or request in-progress Some user has taken up this issue to work on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make search results scrollable benediktms/verve
2 participants
@ParthJadhav @benediktms