MessageForwardingInCaseOfFaultConfig should not be required for sendonly

[outofcoolnames]

When configuring an endpoint as a SendOnly endpoint, in version 5.0.x the user didn't have to define the MessageForwardingInCaseOfFaultConfig configuration. However in 5.1.0 this is now required and the endpoint fails to start unless it is specified.

Steps to repro

• Create a console application and install-package NServiceBus (version 5.0.0)
• Add the following to configure it as send-only

 static void Main(string[] args)
 {
    var busConfiguration = new BusConfiguration();
    busConfiguration.EndpointName("Sample.SendOnly.Client");
    busConfiguration.UseSerialization<JsonSerializer>();
    busConfiguration.UsePersistence<InMemoryPersistence>();
    busConfiguration.EnableInstallers();

    var bus = Bus.CreateSendOnly(busConfiguration);
    Console.ReadLine();
}

• Upgrade this endpoint to 5.1.0 and notice the configuration error

Workaround
Either add the config section, MessageForwardingInCaseOfFaultConfig to app.config or if you don't want to change the app.config, please add the following initialization via code.

using NServiceBus.Config;
using NServiceBus.Config.ConfigurationSource;

class ConfigErrorQueue : IProvideConfiguration<MessageForwardingInCaseOfFaultConfig>
{
    public MessageForwardingInCaseOfFaultConfig GetConfiguration()
    {
        return new MessageForwardingInCaseOfFaultConfig
        {
            ErrorQueue = "error"
        };
    }
}

Hi,

I upgraded from NSB 5.0.1 to 5.1.0 today and now in my WCF web service I'm getting an error stating: Faults forwarding requires an error queue to be specified. Please add a 'MessageForwardingInCaseOfFaultConfig' section to your app.config

This wasn't required on 5.0.1. This is the entire message:

System.Configuration.ConfigurationErrorsException occurred
HResult=-2146232062
Message=Faults forwarding requires an error queue to be specified. Please add a 'MessageForwardingInCaseOfFaultConfig' section to your app.config
or configure a global one using the powershell command: Set-NServiceBusLocalMachineSettings -ErrorQueue {address of error queue}
Source=NServiceBus.Core
BareMessage=Faults forwarding requires an error queue to be specified. Please add a 'MessageForwardingInCaseOfFaultConfig' section to your app.config
or configure a global one using the powershell command: Set-NServiceBusLocalMachineSettings -ErrorQueue {address of error queue}
Line=0
StackTrace:
at NServiceBus.Faults.ErrorQueueSettings.GetConfiguredErrorQueue(ReadOnlySettings settings) in c:\BuildAgent\work\1b05a2fea6e4cd32\src\NServiceBus.Core\Faults\ErrorQueueSettings.cs:line 42

InnerException:

I don't have any issue with adding the configuration to the web.config but I normally prefer to avoid making web.config changes if I can
To reproduce:
Create WCF Service Application, install NSB version 5.0.1(along with NServiceBus.Log4Net and its dependent log4net package)
Add Global.asax
Create ISendOnlyBus Bus within Application_Start
Call Bus.Send within WCF service class <-- builds and runs without issue
Then...
Upgrade to NSB 5.1.0 (the latest at the time of writing)
Observe the error above

[indualagarsamy]

@outofcoolnames - I was able to reproduce this. I've updated the issue description and I have added a workaround to provide config via code, until we fix this.

[indualagarsamy]

@SimonCropp -
In v5.0.3 - this was initialization was as follows:
https://github.com/Particular/NServiceBus/blob/5.0.3/src/NServiceBus.Core/Transports/Msmq/Config/MsmqTransportConfigurator.cs#L28
In v5.1.0 - it was changed to include the error queue as follows:
https://github.com/Particular/NServiceBus/blob/5.1.0/src/NServiceBus.Core/Transports/Msmq/Config/MsmqTransportConfigurator.cs#L30-31
and it was due to trying to fix this: 4ee392f
Since the ForwarderFaultManager is a feature, I am thinking we can disable that if its SendOnly - thoughts?