Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bo bindings do not work inside a bo-if #25

Closed
shanewilson opened this issue Sep 30, 2013 · 4 comments
Closed

bo bindings do not work inside a bo-if #25

shanewilson opened this issue Sep 30, 2013 · 4 comments
Labels

Comments

@shanewilson
Copy link

bo-* directives don't seem to be evaluated when they are inside a bo-if.

http://plnkr.co/edit/bBYB49wfuaBkJs9JfDa9?p=preview

Unless I'm doing something wrong

@Pasvaz
Copy link
Owner

Pasvaz commented Oct 1, 2013

I'll fix it asap, right now I'm quite busy but this will be my next task.

Anyway it's much better to avoid bindonce and ng-repeat on the same element in order to create only one bindonce controller instead of multiple controllers, for instance your script should be:

<div bindonce="items">
      <span ng-repeat="item in items">
        <span bo-if="true">
          <span bo-text="item">this should be replaced</span>
        </span><br>
      </span>
</div>

@shanewilson
Copy link
Author

Ok thanks.

Just so you know, the README says to put them on the same element:

\<ul>
\<li bindonce ng-repeat="person in Persons">
...

@Pasvaz
Copy link
Owner

Pasvaz commented Oct 2, 2013

you are right, the problem is that since the first revision things are changed, with some of the new added attributes (like bo-if) creating one controller per item rather that one controller per repeater can drastically change the result. The readme must be update, I'll make some changes and some clarification when I'll fix this issue.

@AdrienGiboire
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants