Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Whispering Ice & Trigger Conditions #4015

Merged

Conversation

Nostrademous
Copy link
Contributor

@Nostrademous Nostrademous commented Jan 31, 2022

This PR does two things:

  1. Updates Damage Range & Added Damage Effectiveness (it's 1.0 if not specified by default) of Icestorm skill from Whispering Ice to GGG Patch Notes
  2. Fixes trigger conditions for CoC, CoMK and CwC with actives on item versus via gem reguiring same socket group versus same slot name.

PasteBin:
Whispering Ice: https://pastebin.com/tewrkNEj (fails to detect trigger in dev, works with PR)

@Nostrademous Nostrademous added bug Something isn't working enhancement New feature, calculation, or mod labels Jan 31, 2022
@LocalIdentity LocalIdentity merged commit 9b1fbf2 into PathOfBuildingCommunity:dev Feb 1, 2022
@Nostrademous Nostrademous deleted the WhisperingIce branch February 1, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants