Add support for skill uses #5537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuickStick123
changed the title
QuickStick123
changed the title
QuickStick123
changed the title
3 tasks
QuickStick123
force-pushed
the
Stored-Uses
branch
from
d12d6c6
to
801be74
Compare
LocalIdentity
approved these changes
Feb 18, 2023
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
* Add stored uses * lower case and add tooltip * Make implementations generic. * Add proper parsing * typo * Add breakdown and make extracooldown from second wind for non instant skills. * Fix accidently missing readding warcry * Fix forgetting to update .txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This information was missing in PoB and was manually added in existing cases this updates it to be generic and adds a breakdown and tooltip information.
There is an issue where skill uses > 1 seems to let cooldowns not be affected by server ticks which this doesn't implement #5648.
If the maintainers prefer this can be updated to only be shown if greater than 1 (in calcs tab).
Build
https://pobb.in/5Ib0KsCzOcyB
Ingame screenshot:
Before screenshot:
After screenshot: