Split calc defence and only run ehp calcs on first pass of full dps #5773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regisle
force-pushed
the
speedupFullDPSAndCalcDefence
branch
from
21f2f1b
to
d3f17c8
Compare
Nostrademous
approved these changes
Apr 5, 2023
|
LGTM |
LocalIdentity
approved these changes
Apr 5, 2023
3 tasks
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
…athOfBuildingCommunity#5773) * split calc defence and only run ehp calcs on first pass of full dps * fix whitespace * increment skill count only if the skill is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor speed improvement with full dps, but skipping EHP/maxhit calcs where unnecessary
This results in around a 2% speedup per skill in fulldps after the first, a similar thing could be done for minions
(eg with 5 skills total you get around an 8-9% speedup doing something like node power or item sorting)