Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for many crucible mods #6077

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Conversation

LocalIdentity
Copy link
Contributor

@LocalIdentity LocalIdentity commented Apr 19, 2023

The base crit mod was not being added to the base crit of the weapon and instead was being treated as global base crit

Other mods added support for

Your Cold Damage cannot Chill
Minions never deal Critical Strikes
Minion hits can't be Evaded
Minions take 15% increased Damage
Minions take 15% reduced Damage
Minion Critical Strikes do not deal extra Damage
No chance to Block
-1 to Maximum Endurance, Frenzy and Power Charges
Inflict Fire, Cold, and Lightning Exposure on Hit
8% increased Movement Speed if Dexterity is below 100
14% increased Area of Effect if Intelligence is below 100
6% chance to deal Double Damage if Strength is below 100
-20% chance to Block Projectile Spell Damage
+25% chance to Block Projectile Spell Damage
15% chance to inflict Brittle on Enemies when you Block their Damage
15% chance to inflict Sap on Enemies when you Block their Damage
15% chance to inflict Scorch on Enemies when you Block their Damage
Inflict Lightning Exposure on Hit
Inflict Fire Exposure on Hit
Inflict Cold Exposure on Hit
Cannot be Stunned when on Low life
Your Counterattacks have 30% reduced Cooldown Recovery Rate
Your Counterattacks deal 45% more Damage
You take 20% increased Extra Damage from Critical Strikes
Hits have 100% increased Critical Strike Chance against you
Gain 30 Energy Shield when you block
Your travel skills are disabled
Corpses you Spawn have 5% reduced Maximum Life
Offering Skills have 25% increased Duration
Hits against you Overwhelm 6% of Physical Damage Reduction
-5% to amount of Suppressed Spell Damage Prevented
Unaffected by Chill while Channelling
Unaffected by Shock while Channelling

@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Apr 19, 2023
@QuickStick123
Copy link
Contributor

Fixes #6048

@LocalIdentity LocalIdentity changed the title Fix Crucible mods not adding base crit to weapons Add support for many crucible mods Apr 19, 2023
@LocalIdentity LocalIdentity merged commit ae51807 into dev Apr 20, 2023
@LocalIdentity LocalIdentity deleted the fix_crucible-base-crit branch April 20, 2023 13:45
Dullson pushed a commit to Dullson/PathOfBuilding that referenced this pull request Dec 6, 2023
* Fix Crucible mods not adding base crit to weapons

* Add support for many more mods

* Clean up mod formatting

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants