Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when searching for Timeless Jewel and using filter nodes #6170

Merged
merged 1 commit into from
May 2, 2023
Merged

Fix crash when searching for Timeless Jewel and using filter nodes #6170

merged 1 commit into from
May 2, 2023

Conversation

Regisle
Copy link
Member

@Regisle Regisle commented Apr 30, 2023 •
edited
Loading

fixes #6166

@QuickStick123 QuickStick123 added the crash Causes PoB to crash and is High Priority label Apr 30, 2023
@LocalIdentity LocalIdentity changed the title fix filter distance is nil crash Fix crash when searching for Timeless Jewel and using filter nodes May 2, 2023
@LocalIdentity LocalIdentity merged commit 8ec1dad into PathOfBuildingCommunity:dev May 2, 2023
@Regisle Regisle deleted the FilterDistanceCrash branch May 3, 2023 00:58
@Losian
Copy link

Losian commented May 15, 2023

Still having this issue on 2.30.1 -

In 'OnFrame': Classes/TreeTab.lua:1773: attempt to compare num ber with nil
stack traceback:
Classes/TreeTab.lua:1773: in function 'OnKeyUp'
Classes/ControlHost.lua:57: in function 'ProcessControlsInput'
Modules/Main.lua:299: in function <Modules/Main.lua:275>
[C]: in function 'PCall'
..\Launch.lua:107 in function Launch.lua:104

@Wires77 Wires77 mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees
No one assigned
Labels
crash Causes PoB to crash and is High Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Brutal Restraint Timeless Jewel search with fliter node
4 participants
@Regisle @Losian @LocalIdentity @QuickStick123