Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for the "%d more recovery if used while on low life" Life flask mod #7477

Conversation

Nerotox
Copy link
Contributor

@Nerotox Nerotox commented Mar 26, 2024

Description of the problem being solved:

Fixes an issue with the Ikiaho's promise unique where the "Life Flasks used while on Low Life apply Recovery Instantly" mod was checking for low mana instead of low life.

Adds support for the "%d more recovery if used while on low life" mod on life flasks.

Steps taken to verify a working solution:

  • Create a life flask with the "%d more recovery if used while on low life" modifier.
  • Enable the life flask.
  • Tick "Are you always on Low Life?" in the config or reserve over 50% of your life.
  • Check if the Life Recovery changes to the appropriate value when ticking low life.

Link to a build that showcases this PR:

https://pobb.in/TZqJXLdYHrbd

Before screenshot:

image

After screenshot:

image
image

All calculations were tested ingame to verify results.
Resulting values in PoB are slightly off due to rounding errors (under 1 hp/sec off).

@Paliak Paliak added the enhancement New feature, calculation, or mod label Mar 27, 2024
@LocalIdentity LocalIdentity merged commit 6520de0 into PathOfBuildingCommunity:dev Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants