Merge pull request #544 from Varsha-Kulkarni/issue_536

Fix issue 536 loading of progress indefinitely when no notes available
PatilShreyas · Oct 6, 2022 · 07d4f50 · 07d4f50
2 parents 6f26507 + 44cc639
commit 07d4f50
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/...d/app/simpleapp/src/main/java/dev/shreyaspatil/noty/simpleapp/view/notes/NotesFragment.kt b/...d/app/simpleapp/src/main/java/dev/shreyaspatil/noty/simpleapp/view/notes/NotesFragment.kt
@@ -172,8 +172,7 @@ class NotesFragment : BaseFragment<NotesFragmentBinding, NotesState, NotesViewMo
 
     private fun isConnected(): Boolean? = viewModel.currentState.isConnectivityAvailable
 
-    private fun shouldSyncNotes() = viewModel.currentState
-        .let { state -> state.error != null || state.notes.isEmpty() }
+    private fun shouldSyncNotes() = viewModel.currentState.error != null
 
     override fun getViewBinding(
         inflater: LayoutInflater,

diff --git a/noty-api/build.gradle b/noty-api/build.gradle
@@ -23,9 +23,9 @@ buildscript {
         ktorVersion = "1.6.8"
         exposedVersion = "0.39.2"
         postgresVersion = "42.3.1"
-        logbackVersion = "1.4.1"
+        logbackVersion = "1.4.3"
         daggerVersion = "2.44"
-        testContainerVersion = "1.17.4"
+        testContainerVersion = "1.17.5"
         kotestVersion = "5.5.0"
     }