Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not treat undefined the same as null? #15

Open
nmaves opened this issue Mar 8, 2021 · 0 comments
Open

Why not treat undefined the same as null? #15

nmaves opened this issue Mar 8, 2021 · 0 comments

Comments

@nmaves
Copy link

nmaves commented Mar 8, 2021

Curious why there is an explicit null check in the toString(). Why not treat undefined the same as null and use ''? You can see a pattern that we use a lot in our code and it fails because the map at the end returns undefined.

  return new RedisDataLoader(
    'prefix',
    new DataLoader(
      async (ids) => {
        const results = await pool.query(
          `select * from foo where id = any($1)
        `,
          [ids],
        )

        const keyById = keyBy(results.rows, 'id')

        return ids.map((id) => keyById[id])
      },
      { cache: false },
    ),
    {
      ONE_HOUR,
    },
  )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant